[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Re: kdelibs/kdeui
From:       Dirk Mueller <mueller () kde ! org>
Date:       2002-01-30 2:43:20
[Download RAW message or body]

On Die, 29 Jan 2002, Ellis Whitehead wrote:

> With individual commits, though, it does bring up the question of just how 
> insignificant does a patch need to be to forego the "post-it first" rule? 

The point is while one might consider the change insignificant, for somebody 
else it might be very much significant. while reading your commit log I 
remembered we had that already, and we had problems with it. cvs log and 
annotate should give you insights. 

> box or various one-liners like passing a missing argument to a QString 
> construction.

It doesn't matter how long or how short the diff is. a perfectly looking 
one-liner might deeply screw up everything already. I'm more deciding about 
the significance of the related classes. A simple looking change in KConfig 
might trash the users configuration, even if its just about "calling the 
right constructor".  


Dirk
[prev in list] [next in list] [prev in thread] [next in thread]