[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: patch: kaction and kghostview
From:       Wilco Greven <greven () kde ! org>
Date:       2002-01-29 13:03:12
[Download RAW message or body]

On Tuesday 29 January 2002 00:19, Simon Hausmann wrote:
> Hi,
>
> The KActionPtrList class is a recent addition to
> KActionCollection. After a discussion with Ellis it turned out this
> class adds no real value over a plain QValueList<KAction *> , which
> is also what KDE 2's KActionCollection used to have in the API.
>
> Attached is a trivial patch to remove the KActionPtrList class
> again. The only application affected is kghostview. It previously
> used KActionCollection as container for a bunch of action it changes
> (enables/diables) in different states of the part object (initial
> state: lots of actions disabled, document loaded: enable all those) .
> This was changed to KActionPtrList, in particular the code used
> non-qvaluelist methods, so it needs fixing. However I just took the
> chance to convert kghostview to Guillaume's brilliant action state
> pattern :-)

Thanks! I didn't know it existed, but it looks like it is talor made for=20
kghostview.

> Please review / accept / deny / flame the attached patches :)
> (The KAction one is binary incompatible, no source incompatibilities
> with KDE 2 or any other application in the CVS involved though
> (aside from kghostview) , at least that's what lxr.kde.org says :-)

Please apply.

Greetings,
Wilco


[prev in list] [next in list] [prev in thread] [next in thread]