[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [Fwd: End Game bug] kshisen
From:       Gary Park <garypark () pacbell ! net>
Date:       2001-10-14 18:23:41
[Download RAW message or body]

Sirs;
I am sending you this at the request of Mario Weilguni. I have seen by
the bug reports
that I am far from the only person anoyed by this problem.
I do not have CVS access. So I am forwarding this mail to you. I made
these changes
against the source as I found it under slackware 8. As this a recent
release it should be
correct but please verify that the indicated lines are removed from
Board::marked
and inserted into Board::undrawArrow near the end of that function.

Thank you.

Gary Park
garypark@pacbell.net


Return-path: <Mario.Weilguni@kpnqwest.com>
Received: from mta2.snfc21.pbi.net (mta2-pr.snfc21.pbi.net)
 by sims4.snfc21.pbi.net
 (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10)
 with ESMTP id <0GL600G3QXZSZ4@sims4.snfc21.pbi.net> for
 garypark@sims-ms-daemon; Sun, 14 Oct 2001 03:19:05 -0700 (PDT)
Received: from relay12.austria.eu.net ([193.154.160.116])
 by mta2.snfc21.pbi.net (Sun Internet Mail Server sims.3.5.2000.01.05.12.18.p9)
 with ESMTP id <0GL6005XAXZLSV@mta2.snfc21.pbi.net> for
 garypark@sims4.snfc21.pbi.net; Sun, 14 Oct 2001 03:18:59 -0700 (PDT)
Received: from relay2.austria.eu.net (endjinn.austria.eu.net [193.81.13.2])
 by relay12.austria.eu.net (Postfix) with ESMTP id 2EA5FC4159 for
 <garypark@pacbell.net>; Sun, 14 Oct 2001 12:18:56 +0200 (CEST)
Received: from there (wotan.sime.com [193.228.81.42])
 by relay2.austria.eu.net (8.12.0.Beta10/8.12.0.Beta10)
 with SMTP id f9EAIsff013985 for <garypark@pacbell.net>; Sun,
 14 Oct 2001 12:18:55 +0200 (MET DST)
Date: Sun, 14 Oct 2001 12:19:06 +0200
From: Mario Weilguni <Mario.Weilguni@kpnqwest.com>
Subject: Re: End Game bug
In-reply-to: <3BC8866B.983D92A0@pacbell.net>
To: Gary Park <garypark@pacbell.net>
Reply-to: mw@sime.com
Message-id: <200110141018.f9EAIsff013985@relay2.austria.eu.net>
Organization: KPNQwest Austria
MIME-version: 1.0
X-Mailer: KMail [version 1.3.1]
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: quoted-printable
X-Mozilla-Status2: 00000000
References: <3BC8866B.983D92A0@pacbell.net>

Hi!

Excellent. I do not bugfix anymore due to a lack of time. Can you please post 
the patch to kde-core-devel@kde.org, or if you have CVS access apply the 
patch yourself?

Thank you for your contribution!

cu
	Mario

Am Samstag 13 Oktober 2001 20:22 schrieben Sie:
> Mario;
>
> First thank you for the game kshisen.
>
> I have found the often reported end game bug associated with
> the gravity option. The problem is that the check for end of
> game is being done before the tiles fall. After the tiles fall
> it is possible that their new position reveals a new move that
> was not available as the tiles were removed, or covers an old
> move that was available. Thus, both false ends and undetected
> ends are possible. I have tested the changes listed below,
> they seem to have no ill effects.
>
> diff board.cpp kshisen/board.cpp
> 537a538,539
>
> >       int dummyx;
> >       History dummyh[4];
>
> 539,541c541,545
> <       // game is over?
> <       // Must delay until after tiles fall to make this test
> <       // See undrawArrow GP.
> ---
>
> >       // game is over?
> >       if(!getHint_I(dummyx,dummyx,dummyx,dummyx,dummyh)) {
> >       time_for_game = (int)difftime( time((time_t)0), starttime);
> >       emit endOfGame();
> >       }
>
> 712,719d715
> <   int dummyx;
> <   History dummyh[4];
> <   // game is over?
> <   if(!getHint_I(dummyx,dummyx,dummyx,dummyx,dummyh)) {
> <       time_for_game = (int)difftime( time((time_t)0), starttime);
> <       emit endOfGame();
> <   }
> <
>
> Gary Park
> garypark@pacbell.net

-- 
-----------------------------------------------------------------------
 Mario Weilguni                               KPNQwest Austria GmbH
 Senior Engineer Web Solutions                         Nikolaiplatz 4
 tel +43-316-813824                                  8020 graz, austria
 fax +43-316-813824-26                     i http://www.kpnqwest.at
 e mario.weilguni@kpnqwest.com
-----------------------------------------------------------------------


[prev in list] [next in list] [prev in thread] [next in thread]