[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KURL Patch
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2001-10-14 0:53:52
[Download RAW message or body]

On Samstag, 13. Oktober 2001 22:26 Frerich Raabe wrote:

> Agreed. I merged your patch with my current version which renames
> queryValue() to queryItem() (since we're not returning the value of the
> query but rather the value of one of the query's items), saved a few calls
> to _item.length() and item.length() and made it a const method. I also
> adjusted kurltest to cover the issues you pointed out. How about this one?

Apart from the variable names making me dizzy (_item, item, _len, len), it 
looks good to me :)

Cheers
Carsten Pfeiffer

[prev in list] [next in list] [prev in thread] [next in thread]