[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] patchs for kdelibs-2.2.1 and kdebase-2.2.1 to select encoding in control center.
From:       Ilya Konstantinov <kde-core-devel () future ! shiny ! co ! il>
Date:       2001-10-13 12:45:17
[Download RAW message or body]

On Sat, Oct 13, 2001 at 09:19:19PM +0900, Toshitaka Fujioka wrote:
> On Thursday 04 October 2001 17:26, James Su wrote:
> > Hello all,
> 
> Hello,
> 
> > These two patch replace a encoding list instead charset list in control
> > center.
> > according to the source code of klocale.cpp and kcharsets.cpp,
> > KGlobal::locale()->charset() will actually return encoding name (codec
> > name) but not charset name! So, it's better rename
> > KGlobal::locale()->charset() to KGlobal::locale()->encoding(), and
> > rename "Charset" entry in global config file to "Encoding".
> 
> Sorry, I was late to reply.
> 
> KDE_2_2_BRANCH is bug fix only. Your patch isn't bug fix.
> Because, charset is necessary in Qt 2.*.*/KDE 2.*.* .

Right, but the charset in 2.2 is blindly used as an "encoding" by
setting Qt's default codec to it. I think the user should be given all
the available encodings, and the default font charset should be derived
from the encoding via KCharsets::charsetForEncoding (I think that's the
name).

The rule is - each encoding specifies one charset, but one charset
can mean many possible encodings.

[prev in list] [next in list] [prev in thread] [next in thread]