[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] k_dcop_signals
From:       Matthias Ettrich <ettrich () trolltech ! com>
Date:       2001-10-01 9:41:50
[Download RAW message or body]

On Monday 01 October 2001 00:07, Alexander Kellett wrote:
> A few cleanups and the addition of "excludeself" to dcopidl, and
> an optional option excludeself to emitDCOPsignal to match the nice
> API in dcopsignals.*
>
> Oops. This time with a gzipped patch. (cvs diff includes scanner.cc
> and yacc.cc unfortunately)
>
> ciao,
> Alex

Hi Alex,

I'm not sure whether excludeself really should be a property of a signal. 
Isn't it rather a mode of emitting a signal? Waldo, what's your view on this, 
you wrote dcopsignals?

Btw, although it's too late for the function in DCOPSignals,  I'd generally 
prefer an enum variable EmitMode instead of the boolean. It makes it possible 
to add new modes in the future and keeps the code more readable.

If you write

    someFuntion( foo, bar, TRUE );

nobody knows what the TRUE is for. 

The enum version 

   someFunction( foo, bar, SomeClass:ObviousEnum );

helps others to understand the code even years later.

Trolltech unfortunately did the same design mistake on many places in Qt, but 
we are going to avoid it in the future.


Matthias

["Attachment: 1" (application/x-gunzip)]

[prev in list] [next in list] [prev in thread] [next in thread]