[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-community
Subject:    Re: [kde-community] Official KDE mirror on github
From:       Kevin Krammer <krammer () kde ! org>
Date:       2015-09-19 12:54:28
Message-ID: 1967834.YfQNGUMhV3 () persephone
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday, 2015-09-19, 14:43:37, Bhushan Shah wrote:
> On Sat, Sep 19, 2015 at 2:06 PM, Sune Vuorela <nospam@vuorela.dk> wrote:
> > I personally feel a bit fucked over right now. All this started with a
> > KDE github mirror and *just a mirror*. No pull requests. No bugtracker.
> > No nothing else. Just a mirror. And it was repeatedly said in the thread
> > that it would be just a mirror. Just a mirror.
> 
> And when we say mirror and if we start to accept pull request there it
> will also complicate the sysadmin work if I know correctly
> 
> How would git.kde.org will stay up-to-date if you merged pull request
> on github? This is one of the reason currently sysadmin allows pushes
> on just git.kde.org and not on anongit.kde.org

I have to say I don't have any experience with pull requests, whatever those 
are, but since Jaroslaw put the into the context of patches by email I would 
assume that the workflow still has all patches go through proper review, these 
pull request would just be a form of patch submission.

Lets consider an example, say Okular.

If Okular has the policy that nothing is merged without review, then all 
patches for Okular need to go through KDE's review tool 
(reviewboard/gerrit/phabricator/whatever).

If contributors to Okular feel they want to accept submission per email, 
bugzilla attachment or github pull request, then they will still have to 
submit these patches for review, no?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

_______________________________________________
kde-community mailing list
kde-community@kde.org
https://mail.kde.org/mailman/listinfo/kde-community

[prev in list] [next in list] [prev in thread] [next in thread]