[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kdesktop
From:       Geert Jansen <g.t.jansen () stud ! tue ! nl>
Date:       2000-05-27 20:13:05
[Download RAW message or body]

Dawit Alemayehu wrote:

> >  > >  * LRU expiration of command history.
> 
> Hmmm... this should be done automatically ??  The combobox only takes
> 50 URLs by default which is currently only configurable through modifying
> the source file ( kcontrol dialog is MIA ).  When the control dialog is done,
> you can set this value through the control panel to a lower value and thus have
> the list items expire more frequently.  In other words it should not require
> any code whatsoever to do this ( well of course except the control panel code )

Yes, expiration was automatically, but I think it worked in a way that the
lexically last items were deleted, not the last used ones. The list was read
from KCompletion::items() which I think is sorted and so the lexical tail
was deleted.
 
> >  > >  * Some cleanups: this is a QDialog and we may use it.
> 
> Meaning ??  I guess I better look at your code first :)))

Use accept() and reject(), instead of catching hideEvent(). :)
 
> >  What does your cleanup do? You mean binary compatibility of KURL and
> >  related things? Minicli is no shared lib so binary compatibility is a non
> >  issue here.
> 
> Sorry, I confuse way too many things.  Yes indeed any changes I make to Minicli
> has no binary incompatiablity :))  My changes though are just as deep as yours
> although they do not conflict with what you have done....

Great!

Greetings,
-- 
    Geert Jansen                       email: <g.t.jansen at stud.tue.nl>
    Phylosopher, Physicist,                    email: <jansen at kde.org>           
    KDE enthusiast                                 PGP key ID: 0xD2B5E7CE            

[prev in list] [next in list] [prev in thread] [next in thread]