From kde-commits Sat May 27 20:13:05 2000 From: Geert Jansen Date: Sat, 27 May 2000 20:13:05 +0000 To: kde-commits Subject: Re: kdebase/kdesktop X-MARC-Message: https://marc.info/?l=kde-commits&m=95945874707845 Dawit Alemayehu wrote: > > > > * LRU expiration of command history. > > Hmmm... this should be done automatically ?? The combobox only takes > 50 URLs by default which is currently only configurable through modifying > the source file ( kcontrol dialog is MIA ). When the control dialog is done, > you can set this value through the control panel to a lower value and thus have > the list items expire more frequently. In other words it should not require > any code whatsoever to do this ( well of course except the control panel code ) Yes, expiration was automatically, but I think it worked in a way that the lexically last items were deleted, not the last used ones. The list was read from KCompletion::items() which I think is sorted and so the lexical tail was deleted. > > > > * Some cleanups: this is a QDialog and we may use it. > > Meaning ?? I guess I better look at your code first :))) Use accept() and reject(), instead of catching hideEvent(). :) > > What does your cleanup do? You mean binary compatibility of KURL and > > related things? Minicli is no shared lib so binary compatibility is a non > > issue here. > > Sorry, I confuse way too many things. Yes indeed any changes I make to Minicli > has no binary incompatiablity :)) My changes though are just as deep as yours > although they do not conflict with what you have done.... Great! Greetings, -- Geert Jansen email: Phylosopher, Physicist, email: KDE enthusiast PGP key ID: 0xD2B5E7CE