[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kimgio
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-05-20 0:07:01
[Download RAW message or body]

On Fri, May 19, 2000 at 04:57:51PM -0700, Waldo Bastian wrote:
> On Fri, 19 May 2000, David Faure wrote:
> > > > Modified Files:
> > > > 	eps.kimgio xview.cpp
> > > > Log Message:
> > > > This improves EPS support for me:
> > > > -Header=^%25!PS-Adobe
> > > > +Header=^\%!PS-Adobe
> > > > (since it's passed through a QRegExp apparently)
> > >
> > > Ehm!! '%25' stands for '%'. The header string is %-escaped to be able to
> > > enter low-ascii as well.
> >
> > Ah.
> >
> > > Luckily the %-decoder is smarter these days and doesn't try to decode
> > > "%!P" any more, so your change didn't broke anything. (Did it fix
> > > anything??)
> >
> > Well, the file wasn't recognised as an EPS before, and now it is...
> 
> I see... I broke the decoding part :-] I used KURL::decode_string() but 
> forgot to assign the result. KURL::decode() used to modify the argument 
> itself.
> 
> Fixed in kimageio.cpp.
> 
> Would you care to check that it still works after my commit? 

Yes, it works - well it detects EPS, but then ps barfs
Unrecoverable error: rangecheck in .putdeviceprops
[...]

Anyway, the kimgio stuff works :)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]