[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kimgio
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-05-19 23:57:51
[Download RAW message or body]

On Fri, 19 May 2000, David Faure wrote:
> > > Modified Files:
> > > 	eps.kimgio xview.cpp
> > > Log Message:
> > > This improves EPS support for me:
> > > -Header=^%25!PS-Adobe
> > > +Header=^\%!PS-Adobe
> > > (since it's passed through a QRegExp apparently)
> >
> > Ehm!! '%25' stands for '%'. The header string is %-escaped to be able to
> > enter low-ascii as well.
>
> Ah.
>
> > Luckily the %-decoder is smarter these days and doesn't try to decode
> > "%!P" any more, so your change didn't broke anything. (Did it fix
> > anything??)
>
> Well, the file wasn't recognised as an EPS before, and now it is...

I see... I broke the decoding part :-] I used KURL::decode_string() but 
forgot to assign the result. KURL::decode() used to modify the argument 
itself.

Fixed in kimageio.cpp.

Would you care to check that it still works after my commit? 

Cheers,
Waldo

[prev in list] [next in list] [prev in thread] [next in thread]