[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [akregator/Applications/18.04] src: Fix going to prev/next article with keyboard when using load ful
From:       Daniel_Vrátil <null () kde ! org>
Date:       2018-04-30 23:44:55
Message-ID: E1fDITX-0007ly-14 () code ! kde ! org
[Download RAW message or body]

Git commit 420dc9ab048bab6afa91f4dc5effb7033530b98c by Daniel Vrátil, on behalf of \
Thomas Brix Larsen. Committed on 30/04/2018 at 23:44.
Pushed by dvratil into branch 'Applications/18.04'.

Fix going to prev/next article with keyboard when using load full website

Summary:
Articles were loaded three times when keyboard selection was used. This broke \
rendering so the selected article was never rendered. This is a regression as \
keyboard selection was working one or two releases ago.

Test Plan: Set feed to use rendering of full website. Press left/right arrow. See \
different article displayed.

Reviewers: pinaraf

Reviewed By: pinaraf

Subscribers: dvratil, #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D12473

M  +0    -3    src/articlelistview.cpp

https://commits.kde.org/akregator/420dc9ab048bab6afa91f4dc5effb7033530b98c

diff --git a/src/articlelistview.cpp b/src/articlelistview.cpp
index d90b632d..785a88b8 100644
--- a/src/articlelistview.cpp
+++ b/src/articlelistview.cpp
@@ -488,9 +488,6 @@ void ArticleListView::selectIndex(const QModelIndex &idx)
         return;
     }
     setCurrentIndex(idx);
-    clearSelection();
-    Q_ASSERT(selectionModel());
-    selectionModel()->select(idx, QItemSelectionModel::Select | \
QItemSelectionModel::Rows);  scrollTo(idx, PositionAtCenter);
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]