From kde-commits Mon Apr 30 23:44:55 2018 From: =?utf-8?q?Daniel_Vr=C3=A1til?= Date: Mon, 30 Apr 2018 23:44:55 +0000 To: kde-commits Subject: [akregator/Applications/18.04] src: Fix going to prev/next article with keyboard when using load ful Message-Id: X-MARC-Message: https://marc.info/?l=kde-commits&m=152513190802804 Git commit 420dc9ab048bab6afa91f4dc5effb7033530b98c by Daniel Vr=C3=A1til, = on behalf of Thomas Brix Larsen. Committed on 30/04/2018 at 23:44. Pushed by dvratil into branch 'Applications/18.04'. Fix going to prev/next article with keyboard when using load full website Summary: Articles were loaded three times when keyboard selection was used. This bro= ke rendering so the selected article was never rendered. This is a regression as keyboard selection was working one or two releases = ago. Test Plan: Set feed to use rendering of full website. Press left/right arro= w. See different article displayed. Reviewers: pinaraf Reviewed By: pinaraf Subscribers: dvratil, #kde_pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D12473 M +0 -3 src/articlelistview.cpp https://commits.kde.org/akregator/420dc9ab048bab6afa91f4dc5effb7033530b98c diff --git a/src/articlelistview.cpp b/src/articlelistview.cpp index d90b632d..785a88b8 100644 --- a/src/articlelistview.cpp +++ b/src/articlelistview.cpp @@ -488,9 +488,6 @@ void ArticleListView::selectIndex(const QModelIndex &id= x) return; } setCurrentIndex(idx); - clearSelection(); - Q_ASSERT(selectionModel()); - selectionModel()->select(idx, QItemSelectionModel::Select | QItemSelec= tionModel::Rows); scrollTo(idx, PositionAtCenter); } =20