[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [falkon] autotests: Autotests: Add qWait(10) at the end of QtWebEngine tests
From:       David Rosca <null () kde ! org>
Date:       2018-01-31 20:10:36
Message-ID: E1egyiK-0002Fo-Rg () code ! kde ! org
[Download RAW message or body]

Git commit 4124c67c5f1d03fcd792a94af5c72a9b0b8d7c85 by David Rosca.
Committed on 31/01/2018 at 20:04.
Pushed by drosca into branch 'master'.

Autotests: Add qWait(10) at the end of QtWebEngine tests

Otherwise it crashes on exit

M  +3    -1    autotests/tabmodeltest.cpp
M  +2    -0    autotests/webtabtest.cpp
M  +2    -0    autotests/webviewtest.cpp

https://commits.kde.org/falkon/4124c67c5f1d03fcd792a94af5c72a9b0b8d7c85

diff --git a/autotests/tabmodeltest.cpp b/autotests/tabmodeltest.cpp
index 92123af3..77756eb7 100644
--- a/autotests/tabmodeltest.cpp
+++ b/autotests/tabmodeltest.cpp
@@ -94,6 +94,7 @@ void TabModelTest::basicTest()
     ModelTest modelTest2(&model2);
     QCOMPARE(model2.rowCount(), 1);
 
+    QTest::qWait(10);
     delete w;
 }
 
@@ -117,6 +118,7 @@ void TabModelTest::dataTest()
 
     WebTab *tab1 = w->weView(1)->webTab();
 
+    QTest::qWait(10);
     delete w;
 }
 void TabModelTest::treeModelTest()
@@ -213,7 +215,7 @@ void TabModelTest::treeModelTest()
     QCOMPARE(model.index(2, 0).data(TabModel::WebTabRole).value<WebTab*>(), tab5);
     QCOMPARE(model.index(3, 0).data(TabModel::WebTabRole).value<WebTab*>(), tab6);
 
-    QTest::qWait(1);
+    QTest::qWait(10);
     delete w;
 }
 
diff --git a/autotests/webtabtest.cpp b/autotests/webtabtest.cpp
index 632722fb..da204393 100644
--- a/autotests/webtabtest.cpp
+++ b/autotests/webtabtest.cpp
@@ -70,6 +70,8 @@ void WebTabTest::parentChildTabsTest()
     QCOMPARE(tab3.parentTab(), &tab1);
     QCOMPARE(tab3.childTabs(), QVector<WebTab*>{&tab4});
     QCOMPARE(tab4.parentTab(), &tab3);
+
+    QTest::qWait(10);
 }
 
 FALKONTEST_MAIN(WebTabTest)
diff --git a/autotests/webviewtest.cpp b/autotests/webviewtest.cpp
index 1e9380de..18ee3d0f 100644
--- a/autotests/webviewtest.cpp
+++ b/autotests/webviewtest.cpp
@@ -101,6 +101,8 @@ void WebViewTest::loadSignalsChangePageTest()
 
     QTRY_COMPARE(loadStartedSpy.count(), 1);
     QCOMPARE(loadFinishedSpy.count(), 0);
+
+    QTest::qWait(10);
 }
 
 FALKONTEST_MAIN(WebViewTest)

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic