[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [falkon] src/lib/tabwidget: TabWidget: Correctly emit tabRemoved when detaching tab
From:       David Rosca <null () kde ! org>
Date:       2018-01-31 20:10:36
Message-ID: E1egyiK-0002Fo-Ve () code ! kde ! org
[Download RAW message or body]

Git commit ebaab19f886068d6ba619ae631bef248eab50834 by David Rosca.
Committed on 31/01/2018 at 20:05.
Pushed by drosca into branch 'master'.

TabWidget: Correctly emit tabRemoved when detaching tab

M  +5    -1    src/lib/tabwidget/tabwidget.cpp

https://commits.kde.org/falkon/ebaab19f886068d6ba619ae631bef248eab50834

diff --git a/src/lib/tabwidget/tabwidget.cpp b/src/lib/tabwidget/tabwidget.cpp
index f1396b1f..32ae4d11 100644
--- a/src/lib/tabwidget/tabwidget.cpp
+++ b/src/lib/tabwidget/tabwidget.cpp
@@ -651,7 +651,12 @@ void TabWidget::detachTab(WebTab* tab)
     disconnect(tab->webView(), SIGNAL(urlChanged(QUrl)), this, SIGNAL(changed()));
     disconnect(tab->webView(), SIGNAL(ipChanged(QString)), m_window->ipLabel(), SLOT(setText(QString)));
 
+    const int index = tab->tabIndex();
+
     tab->detach();
+    tab->setPinned(false);
+
+    emit tabRemoved(index);
 
     if (count() == 0) {
         m_window->close();
@@ -668,7 +673,6 @@ void TabWidget::detachTab(int index)
     }
 
     detachTab(tab);
-    tab->setPinned(false);
 
     BrowserWindow* window = mApp->createWindow(Qz::BW_NewWindow);
     window->setStartTab(tab);

[prev in list] [next in list] [prev in thread] [next in thread]