[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [krita] libs/ui/widgets: Fix arguments to i18nc(), remove extraneous QString copy for memory usage i
From:       Nicholas LaPointe <null () kde ! org>
Date:       2018-01-01 3:25:33
Message-ID: E1eVqjF-0007cf-VC () code ! kde ! org
[Download RAW message or body]

Git commit d81d45a83cf48aeff3f738ec2e0595462ef1807c by Nicholas LaPointe.
Committed on 01/01/2018 at 03:25.
Pushed by nicholasl into branch 'master'.

Fix arguments to i18nc(), remove extraneous QString copy for memory usage info in \
"New" dialog

M  +8    -8    libs/ui/widgets/kis_custom_image_widget.cc

https://commits.kde.org/krita/d81d45a83cf48aeff3f738ec2e0595462ef1807c

diff --git a/libs/ui/widgets/kis_custom_image_widget.cc \
b/libs/ui/widgets/kis_custom_image_widget.cc index aef7fe05d62..c88ecd7a7f0 100644
--- a/libs/ui/widgets/kis_custom_image_widget.cc
+++ b/libs/ui/widgets/kis_custom_image_widget.cc
@@ -504,14 +504,14 @@ void KisCustomImageWidget::changeDocumentInfoLabel()
         layerSize/=1024;
         byte = i18nc("Abbreviation for gigabyte", "GB");
     }
-    QString text = QString(i18nc("arg1: width. arg2: height. arg3: colorspace name. \
                arg4: size of a channel in bits. arg5: size in unites of arg6. Arg6: \
                KB, MB or GB",
-                                 "This document will be %1 pixels by %2 pixels in \
%3, which means the pixel size is %4 bit. A single paint layer will thus take up %5 \
                %6 of RAM."))
-            .arg(width)
-            .arg(height)
-            .arg(cs->name())
-            .arg(bitSize)
-            .arg(layerSize)
-            .arg(byte);
+    QString text = i18nc("arg1: width. arg2: height. arg3: colorspace name. arg4: \
size of a channel in bits. arg5: size in unites of arg6. Arg6: KB, MB or GB", +       \
"This document will be %1 pixels by %2 pixels in %3, which means the pixel size is %4 \
bit. A single paint layer will thus take up %5 %6 of RAM.", +                         \
width, +                         height,
+                         cs->name(),
+                         bitSize,
+                         layerSize,
+                         byte);
     lblDocumentInfo->setText(text);
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]