[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: [kdelibs4support] src/kdeui: Use more correct and with c++11 avalible std::remove_pointer
From: Raymond Wooninck <tittiatcoke () gmail ! com>
Date: 2016-09-08 12:08:58
Message-ID: 2522936.K2Od3WObkJ () hqvmt44011 ! eur ! cchbc ! com
[Download RAW message or body]
On Thursday, 8 September 2016 09:55:50 CEST Hannah von Reth wrote:
> Git commit 94448217b42812f0b4dc063024b9b26915241d86 by Hannah von Reth.
> Committed on 08/09/2016 at 09:55.
> Pushed by vonreth into branch 'master'.
>
> Use more correct and with c++11 avalible std::remove_pointer
>
> M +1 -11 src/kdeui/k4style.h
>
Unfortunately, this change now breaks the build with the following error :
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: error: dependent-name
'std::remove_pointer<T>::type' is parsed as a non-type, but instantiation yields a type
[ 271s] if (qstrcmp(typeid(*option).name(),
typeid(std::remove_pointer<T>::type()).name()) == 0) {
[ 271s] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: note: say 'typename
std::remove_pointer<T>::type' if a type is meant
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.h: In instantiation of 'static T
K4Style::extractOption(K4Style::Option*) [with T = K4Style::TitleButtonOption*]':
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.cpp:679:65: required from here
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: error: dependent-name
'std::remove_pointer<T>::type' is parsed as a non-type, but instantiation yields a type
[ 271s] /home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.
20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: note: say 'typename
std::remove_pointer<T>::type' if a type is meant
Raymond
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Noto Sans'; font-size:11pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">On Thursday, 8 September 2016 09:55:50 CEST Hannah von Reth \
wrote:</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Git \
commit 94448217b42812f0b4dc063024b9b26915241d86 by Hannah von Reth.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Committed on 08/09/2016 \
at 09:55.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Pushed \
by vonreth into branch 'master'.</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> Use more correct and with c++11 avalible \
std::remove_pointer</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> M +1 -11 src/kdeui/k4style.h</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Unfortunately, this change \
now breaks the build with the following error :</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><a name="log_space"></a><span \
style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[</span><span style=" font-family:'monospace'; \
color:#333333; background-color:#f6f6f6;"> 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: \
error: dependent-name 'std::remove_pointer<T>::type' is parsed as a non-type, \
but instantiation yields a type</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:10px; margin-right:10px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] if (qstrcmp(typeid(*option).name(), \
typeid(std::remove_pointer<T>::type()).name()) == 0) {</span></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:10px; margin-right:10px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:10px; margin-right:10px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: \
note: say 'typename std::remove_pointer<T>::type' if a type is meant</span></p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:10px; margin-right:10px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.h: \
In instantiation of 'static T K4Style::extractOption(K4Style::Option*) [with T = \
K4Style::TitleButtonOption*]':</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:10px; margin-right:10px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.cpp:679:65: \
required from here</span></p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:10px; margin-right:10px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0; line-height:26.6667px; background-color:#f6f6f6;"><span style=" \
font-family:'monospace'; color:#333333; background-color:#f6f6f6;">[ 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: \
error: dependent-name 'std::remove_pointer<T>::type' is parsed as a non-type, \
but instantiation yields a type</span></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:10px; margin-right:10px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0; line-height:26.6667px; \
background-color:#f6f6f6;"><span style=" font-family:'monospace'; color:#333333; \
background-color:#f6f6f6;">[ 271s] \
/home/abuild/rpmbuild/BUILD/kdelibs4support-5.26.0git.20160908T130410~75897d2/src/kdeui/k4style.h:1590:80: \
note: say 'typename std::remove_pointer<T>::type' if a type is meant</span></p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br /> Regards</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Raymond</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic