[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: [kdepim/Applications/15.08] libksieve/ksieveui: Fix memory leak and crash in ManageSieveScriptsD
From: Daniel =?ISO-8859-1?Q?Vr=E1til?= <dvratil () redhat ! com>
Date: 2015-09-15 13:01:30
Message-ID: 2417658.cWZmWo4O3D () thor
[Download RAW message or body]
On Tuesday, September 15, 2015 1:26:31 PM CEST laurent Montel wrote:
> Hi,
> This patch is incorrect in this branch :)
> We don't have private class
> => it will not compile for sur :)
> Could you fix it please ?
> thanks
Ooops, sorry. I reverted the commit in stable, as if there's no private class,
then there's nothing to trigger the crash :-)
Dan
>
> Le mardi 15 septembre 2015, 11:20:03 CEST Dan Vrátil a écrit :
> > Git commit 9c1a1d87503d4e12990b93dcab63941c7e91ab8f by Dan Vrátil.
> > Committed on 15/09/2015 at 11:19.
> > Pushed by dvratil into branch 'Applications/15.08'.
> >
> > Fix memory leak and crash in ManageSieveScriptsDialog
> >
> > M +3 -0 libksieve/ksieveui/managesievescriptsdialog.cpp
> >
> > http://commits.kde.org/kdepim/9c1a1d87503d4e12990b93dcab63941c7e91ab8f
> >
> > diff --git a/libksieve/ksieveui/managesievescriptsdialog.cpp
> > b/libksieve/ksieveui/managesievescriptsdialog.cpp index e6e5acc..8e2f413
> > 100644
> > --- a/libksieve/ksieveui/managesievescriptsdialog.cpp
> > +++ b/libksieve/ksieveui/managesievescriptsdialog.cpp
> > @@ -152,6 +152,9 @@ ManageSieveScriptsDialog::~ManageSieveScriptsDialog()
> >
> > {
> >
> > KConfigGroup group(KSharedConfig::openConfig(),
> >
> > "ManageSieveScriptsDialog"); group.writeEntry("Size", size());
> > + // prevent QTreeWidget signals triggered by it's desctructor from
> > calling our slots + d->mTreeView->disconnect(this);
> > + delete d;
> >
> > }
> >
> > void ManageSieveScriptsDialog::hideEvent(QHideEvent *event)
--
Daniel Vrátil | dvratil@redhat.com | dvratil on #kde-devel, #kontact, #akonadi
Software Engineer - Desktop Team, Red Hat Inc.
GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic