From kde-commits  Tue Sep 15 13:01:30 2015
From: Daniel =?ISO-8859-1?Q?Vr=E1til?= <dvratil () redhat ! com>
Date: Tue, 15 Sep 2015 13:01:30 +0000
To: kde-commits
Subject: Re: [kdepim/Applications/15.08] libksieve/ksieveui: Fix memory leak and crash in ManageSieveScriptsD
Message-Id: <2417658.cWZmWo4O3D () thor>
X-MARC-Message: https://marc.info/?l=kde-commits&m=144232212505840
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2896674.3oy3kCZV72"

--nextPart2896674.3oy3kCZV72
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Tuesday, September 15, 2015 1:26:31 PM CEST laurent Montel wrote:
> Hi,
> This patch is incorrect in this branch :)
> We don't have private class
> =3D> it will not compile for sur :)
> Could you fix it please ?
> thanks

Ooops, sorry. I reverted the commit in stable, as if there's no private cla=
ss,=20
then there's nothing to trigger the crash :-)

Dan


>=20
> Le mardi 15 septembre 2015, 11:20:03 CEST Dan Vr=E1til a =E9crit :
> > Git commit 9c1a1d87503d4e12990b93dcab63941c7e91ab8f by Dan Vr=E1til.
> > Committed on 15/09/2015 at 11:19.
> > Pushed by dvratil into branch 'Applications/15.08'.
> >=20
> > Fix memory leak and crash in ManageSieveScriptsDialog
> >=20
> > M  +3    -0    libksieve/ksieveui/managesievescriptsdialog.cpp
> >=20
> > http://commits.kde.org/kdepim/9c1a1d87503d4e12990b93dcab63941c7e91ab8f
> >=20
> > diff --git a/libksieve/ksieveui/managesievescriptsdialog.cpp
> > b/libksieve/ksieveui/managesievescriptsdialog.cpp index e6e5acc..8e2f413
> > 100644
> > --- a/libksieve/ksieveui/managesievescriptsdialog.cpp
> > +++ b/libksieve/ksieveui/managesievescriptsdialog.cpp
> > @@ -152,6 +152,9 @@ ManageSieveScriptsDialog::~ManageSieveScriptsDialog=
()
> >=20
> >  {
> > =20
> >      KConfigGroup group(KSharedConfig::openConfig(),
> >=20
> > "ManageSieveScriptsDialog"); group.writeEntry("Size", size());
> > +    // prevent QTreeWidget signals triggered by it's desctructor from
> > calling our slots +    d->mTreeView->disconnect(this);
> > +    delete d;
> >=20
> >  }
> > =20
> >  void ManageSieveScriptsDialog::hideEvent(QHideEvent *event)

=2D-=20
Daniel Vr=E1til | dvratil@redhat.com | dvratil on #kde-devel, #kontact, #ak=
onadi
Software Engineer - Desktop Team, Red Hat Inc.

GPG Key: 0xC59D614F6F4AE348
=46ingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
--nextPart2896674.3oy3kCZV72
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJV+BaqAAoJEMWdYU9vSuNIAYoH/06c8hAI33VsR5ByypooSLfR
ML3RhbGz/F4A5n3/IAN37DplXkAr/jh6G6RNJAav+RrSuu+Ul6cHkQWjp9fYfRka
5+91VjndhF2x0niUM4sj0juI2wZANEg77xBEoFNixYLMCZlNTSXn0JDfYDNDPynT
U9MEI9JTwEsMshzmu3M9ncFLdr3UgzOMW69VAioxvJpBI9GXq4/Mcgfn9nhYuAlV
9oItmwIAOLYIICFdbK5BPWHlSFdmL8oy/kbM5gDz46tLzSCboq7jw6xGz9oS/jWm
TYjAZf8ak9RBQwJgFkxZ2P7e+/qjnwllyrODutxFFMsO249GvdICSBuX/pCsWyk=
=JSpj
-----END PGP SIGNATURE-----

--nextPart2896674.3oy3kCZV72--