[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim/KDE/4.14] libkdepim/addressline: Fix Bug 336163 - autocompletion shows multiple entries 
From:       André_Wöbbeking <Woebbeking () kde ! org>
Date:       2015-02-04 14:09:39
Message-ID: 1768988.zQ3KPqjqSo () sol
[Download RAW message or body]

On Wednesday 04 February 2015 11:15:49 laurent Montel wrote:
> Le Wednesday 04 February 2015 10:51:08 André Wöbbeking a écrit :
> > On Wednesday 04 February 2015 08:34:32 Montel Laurent wrote:
> > > Git commit 84a0945c2e0c00de317de50e7f0c9e0156d08071 by Montel Laurent.
> > > Committed on 04/02/2015 at 08:33.
> > > Pushed by mlaurent into branch 'KDE/4.14'.
> > > 
> > > Fix Bug 336163 - autocompletion shows multiple entries for one contact
> > > with
> > > different quotes
> > 
> > Sounds cool :-)
> > 
> > BTW, thanks that you put so much time into improving KDEPIM!
> > 
> > > +void
> > > BalooCompletionEmailTest::shouldExcludeDuplicateEntryWithDisplayName()
> > > +{
> > > +    KPIM::BalooCompletionEmail completion;
> > > +    QStringList emailList;
> > > +    emailList << QLatin1String("John Doe <doe@example.com>");
> > > +    emailList << QLatin1String("\"John Doe\" <doe@example.com>");
> > > +    emailList << QLatin1String("\"\'John Doe\'\" <doe@example.com>");
> > 
> > What about "John Doe <Doe@example.com>"? Shouldn't this be case
> > insensitive?
> It's aways done in this class.
> 
> But indeed I missed to add a unit test for it.
> I will do.

Thanks, but it doesn't work for me :-( When I type john I get

Personal Contacts
  John Doe <John.Doe@example.com>
Contacts found in your data
  John Doe <john.doe@example.com>
  Doe John <John.Doe@example.com>
  John.Doe@example.com

Shouldn't the contacts found by Baloo be filtered?
[prev in list] [next in list] [prev in thread] [next in thread]