[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim/KDE/4.14] libkdepim/addressline: Fix Bug 336163 - autocompletion shows multiple entries 
From:       laurent Montel <montel () kde ! org>
Date:       2015-02-04 10:15:49
Message-ID: 12738186.AnjZ55rEVD () linux-19td
[Download RAW message or body]

Le Wednesday 04 February 2015 10:51:08 André Wöbbeking a écrit :
> On Wednesday 04 February 2015 08:34:32 Montel Laurent wrote:
> > Git commit 84a0945c2e0c00de317de50e7f0c9e0156d08071 by Montel Laurent.
> > Committed on 04/02/2015 at 08:33.
> > Pushed by mlaurent into branch 'KDE/4.14'.
> > 
> > Fix Bug 336163 - autocompletion shows multiple entries for one contact
> > with
> > different quotes
> 
> Sounds cool :-)
> 
> BTW, thanks that you put so much time into improving KDEPIM!
> 
> > +void
> > BalooCompletionEmailTest::shouldExcludeDuplicateEntryWithDisplayName() +{
> > +    KPIM::BalooCompletionEmail completion;
> > +    QStringList emailList;
> > +    emailList << QLatin1String("John Doe <doe@example.com>");
> > +    emailList << QLatin1String("\"John Doe\" <doe@example.com>");
> > +    emailList << QLatin1String("\"\'John Doe\'\" <doe@example.com>");
> 
> What about "John Doe <Doe@example.com>"? Shouldn't this be case insensitive?

It's aways done in this class.

But indeed I missed to add a unit test for it.
I will do.

> 
> Cheers,
> André

-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


[prev in list] [next in list] [prev in thread] [next in thread]