[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim-runtime/KDE/4.13] resources/pop3/wizard: rename pop3wizard.js to pop3wizard.es
From:       Pino Toscano <toscano.pino () tiscali ! it>
Date:       2014-03-22 14:08:40
Message-ID: f16ecf52135febb84a8ed5dfcebf63cb () tiscali ! it
[Download RAW message or body]

Il 22.03.2014 15:55 laurent Montel ha scritto:

> Le Saturday 22 March 2014 13:33:02 Pino Toscano a écrit :
>
>> Il 22.03.2014 14:00 laurent Montel ha scritto:
>>
>>> It will good to test changes before to commit
>>> !()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.e
>>> s:61" Kross: "Error error=ReferenceError: Can't find variable:
>>> connect lineno=61
>>> 
>>> trace=()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.e
>>> s:61" Please revert or fix it.
>> Sure, I should have fixed it now.
>>
>>> There was a reason why I didn't change it.
>> But nevertheless you changed it by making a UI-visible string no 
>> more
>> translatable. Breaking i18n like this, without telling anyone, is 
>> *not*
>> an option either.
>
> Yes but it never worked so it doesn't break it because apps didn"t 
> work
> before after old changes.
>
> So when qsTr was added without testing it broke acccountwizard...

Did you tell Luigi about this, then?

> So it was not an option too to break accountwizard.

Like you told me earlier: "please fix it". You caused and i18n
regression, and other people (Luigi) worked on that to have proper i18n
support in those scripts.

Please do not consider i18n as what can be "sacrificed" to make things
work again.

-- 
Pino Toscano

Scopri istella, il nuovo motore per il web italiano.
Istella garantisce risultati di qualità e la possibilità di 
condividere, in modo semplice e veloce, documenti, immagini, audio e 
video.
Usa istella, vai su http://www.istella.it?wtk=amc138614816829636


[prev in list] [next in list] [prev in thread] [next in thread]