[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim-runtime/KDE/4.13] resources/pop3/wizard: rename pop3wizard.js to pop3wizard.es
From:       laurent Montel <montel () kde ! org>
Date:       2014-03-22 13:56:06
Message-ID: 3571697.2l7ihdXTjU () linux-7fma
[Download RAW message or body]

Le Saturday 22 March 2014 13:33:02 Pino Toscano a écrit :
> Il 22.03.2014 14:00 laurent Montel ha scritto:
> > It will good to test changes before to commit !
> > 
> > 
> > <anonymous>()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.e
> > s:61" Kross: "Error error=ReferenceError: Can't find variable: connect
> > lineno=61
> > trace=
> > 
> > <anonymous>()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.e
> > s:61"
> > 
> > 
> > Please revert or fix it.
> 
> Sure, I should have fixed it now.
> 
> > There was a reason why I didn't change it.
> 
> But nevertheless you changed it by making a UI-visible string no more
> translatable. Breaking i18n like this, without telling anyone, is *not*
> an option either.

Yes but it never worked so it doesn't break it because apps didn"t work before 
after old changes.

So when qsTr was added without testing it broke acccountwizard...
So it was not an option too to break accountwizard.


-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]