[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdevelop/4.6] app/welcomepage: WelcomePage: Don't use huge icon sizes
From:       Kevin Funk <krf () gmx ! de>
Date:       2013-12-30 14:07:53
Message-ID: 13226138.qnniOjtiEE () kerberos
[Download RAW message or body]

Am Montag, 30. Dezember 2013, 02:26:11 schrieb Aleix Pol:
> On Sat, Dec 28, 2013 at 9:14 PM, Kevin Funk <kevin@kfunk.org> wrote:
> > Git commit 7e6e23f8f807651dcfe1e8be0b42ff83340db3d0 by Kevin Funk.
> > Committed on 28/12/2013 at 20:08.
> > Pushed by kfunk into branch '4.6'.
> > 
> > WelcomePage: Don't use huge icon sizes
> > 
> > IMO the huge "bug" icon in the lower left of the debug area
> > looks really distracting, decreasing the size.
> > 
> > Also decrease the size of the "KDevelop" icon in the lower right.
> > Looks much better now.
> > 
> > Other opinions?
> > 
> > M  +1    -1    app/welcomepage/StandardBackground.qml
> > M  +2    -2    app/welcomepage/StandardPage.qml
> > 
> > http://commits.kde.org/kdevelop/7e6e23f8f807651dcfe1e8be0b42ff83340db3d0
> > 
> > diff --git a/app/welcomepage/StandardBackground.qml
> > b/app/welcomepage/StandardBackground.qml
> > index 8a60d8e..804e5ed 100644
> > --- a/app/welcomepage/StandardBackground.qml
> > +++ b/app/welcomepage/StandardBackground.qml
> > @@ -61,7 +61,7 @@ Rectangle
> > 
> >              left: parent.left
> >              margins: 5
> >          
> >          }
> > 
> > -        width: 256
> > +        width: 64
> > 
> >          height: width
> >      
> >      }
> >  
> >  }
> > 
> > diff --git a/app/welcomepage/StandardPage.qml
> > b/app/welcomepage/StandardPage.qml
> > index f057c71..d758a15 100644
> > --- a/app/welcomepage/StandardPage.qml
> > +++ b/app/welcomepage/StandardPage.qml
> > @@ -34,8 +34,8 @@ PlasmaCore.FrameSvgItem {
> > 
> >              margins: 5
> >          
> >          }
> >          opacity: 0.3
> > 
> > -        width: 256
> > +        width: 128
> > 
> >          height: width
> >          icon: "kdevelop"
> >      
> >      }
> > 
> > -}
> > \ No newline at end of file
> > +}
> 
> Personally, I actually liked it better before, but I did it and I know
> people don't really like what I do. So if you really think this adds, I'm
> ok with it.
> 
> Said that, I don't think these changes should go to the 4.6 branch.
> 
> Aleix

The huge bug icon really looked kinda creepy :)

You're right -- I reverted the change in the 4.6 branch and re-applied it to 
master.

Thanks

-- 
Kevin Funk
[prev in list] [next in list] [prev in thread] [next in thread]