[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdevelop/4.6] app/welcomepage: WelcomePage: Don't use huge icon sizes
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2013-12-30 1:26:11
Message-ID: CACcA1RpvCLAb3S3FcoOHYXTGEKJy1yCKN8g2A9g92eKaziY7KA () mail ! gmail ! com
[Download RAW message or body]

On Sat, Dec 28, 2013 at 9:14 PM, Kevin Funk <kevin@kfunk.org> wrote:

> Git commit 7e6e23f8f807651dcfe1e8be0b42ff83340db3d0 by Kevin Funk.
> Committed on 28/12/2013 at 20:08.
> Pushed by kfunk into branch '4.6'.
>
> WelcomePage: Don't use huge icon sizes
>
> IMO the huge "bug" icon in the lower left of the debug area
> looks really distracting, decreasing the size.
>
> Also decrease the size of the "KDevelop" icon in the lower right.
> Looks much better now.
>
> Other opinions?
>
> M  +1    -1    app/welcomepage/StandardBackground.qml
> M  +2    -2    app/welcomepage/StandardPage.qml
>
> http://commits.kde.org/kdevelop/7e6e23f8f807651dcfe1e8be0b42ff83340db3d0
>
> diff --git a/app/welcomepage/StandardBackground.qml
> b/app/welcomepage/StandardBackground.qml
> index 8a60d8e..804e5ed 100644
> --- a/app/welcomepage/StandardBackground.qml
> +++ b/app/welcomepage/StandardBackground.qml
> @@ -61,7 +61,7 @@ Rectangle
>              left: parent.left
>              margins: 5
>          }
> -        width: 256
> +        width: 64
>          height: width
>      }
>  }
> diff --git a/app/welcomepage/StandardPage.qml
> b/app/welcomepage/StandardPage.qml
> index f057c71..d758a15 100644
> --- a/app/welcomepage/StandardPage.qml
> +++ b/app/welcomepage/StandardPage.qml
> @@ -34,8 +34,8 @@ PlasmaCore.FrameSvgItem {
>              margins: 5
>          }
>          opacity: 0.3
> -        width: 256
> +        width: 128
>          height: width
>          icon: "kdevelop"
>      }
> -}
> \ No newline at end of file
> +}
>
>
Personally, I actually liked it better before, but I did it and I know
people don't really like what I do. So if you really think this adds, I'm
ok with it.

Said that, I don't think these changes should go to the 4.6 branch.

Aleix

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, \
Dec 28, 2013 at 9:14 PM, Kevin Funk <span dir="ltr">&lt;<a \
href="mailto:kevin@kfunk.org" \
target="_blank">kevin@kfunk.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Git commit 7e6e23f8f807651dcfe1e8be0b42ff83340db3d0 by Kevin Funk.<br>
Committed on 28/12/2013 at 20:08.<br>
Pushed by kfunk into branch &#39;4.6&#39;.<br>
<br>
WelcomePage: Don&#39;t use huge icon sizes<br>
<br>
IMO the huge &quot;bug&quot; icon in the lower left of the debug area<br>
looks really distracting, decreasing the size.<br>
<br>
Also decrease the size of the &quot;KDevelop&quot; icon in the lower \
right.<br> Looks much better now.<br>
<br>
Other opinions?<br>
<br>
M   +1      -1      app/welcomepage/StandardBackground.qml<br>
M   +2      -2      app/welcomepage/StandardPage.qml<br>
<br>
<a href="http://commits.kde.org/kdevelop/7e6e23f8f807651dcfe1e8be0b42ff83340db3d0" \
target="_blank">http://commits.kde.org/kdevelop/7e6e23f8f807651dcfe1e8be0b42ff83340db3d0</a><br>
 <br>
diff --git a/app/welcomepage/StandardBackground.qml \
b/app/welcomepage/StandardBackground.qml<br> index 8a60d8e..804e5ed \
                100644<br>
--- a/app/welcomepage/StandardBackground.qml<br>
+++ b/app/welcomepage/StandardBackground.qml<br>
@@ -61,7 +61,7 @@ Rectangle<br>
                    left: parent.left<br>
                    margins: 5<br>
              }<br>
-            width: 256<br>
+            width: 64<br>
              height: width<br>
        }<br>
  }<br>
diff --git a/app/welcomepage/StandardPage.qml \
b/app/welcomepage/StandardPage.qml<br> index f057c71..d758a15 100644<br>
--- a/app/welcomepage/StandardPage.qml<br>
+++ b/app/welcomepage/StandardPage.qml<br>
@@ -34,8 +34,8 @@ PlasmaCore.FrameSvgItem {<br>
                    margins: 5<br>
              }<br>
              opacity: 0.3<br>
-            width: 256<br>
+            width: 128<br>
              height: width<br>
              icon: &quot;kdevelop&quot;<br>
        }<br>
-}<br>
\ No newline at end of file<br>
+}<br>
<br>
</blockquote></div><br></div><div class="gmail_extra">Personally, I \
actually liked it better before, but I did it and I know people don&#39;t \
really like what I do. So if you really think this adds, I&#39;m ok with \
it.</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">Said that, I \
don&#39;t think these changes should go to the 4.6 branch.</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Aleix</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]