[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-framework] src/declarativeimports/core: sliding popups are back
From:       Marco Martin <notmart () gmail ! com>
Date:       2013-10-18 15:47:18
Message-ID: E1VXCGk-0008UT-NQ () scm ! kde ! org
[Download RAW message or body]

Git commit 391d6ea70b5bc6c82e86f66ec7536f22cd1497e1 by Marco Martin.
Committed on 18/10/2013 at 15:46.
Pushed by mart into branch 'master'.

sliding popups are back

M  +23   -1    src/declarativeimports/core/dialog.cpp

http://commits.kde.org/plasma-framework/391d6ea70b5bc6c82e86f66ec7536f22cd1497e1

diff --git a/src/declarativeimports/core/dialog.cpp b/src/declarativeimports/core/dialog.cpp
index 33bd442..a24d967 100644
--- a/src/declarativeimports/core/dialog.cpp
+++ b/src/declarativeimports/core/dialog.cpp
@@ -145,8 +145,30 @@ void DialogProxy::setVisible(const bool visible)
         }
 
         raise();
+        //DialogShadows::self()->addWindow(this, m_frameSvgItem->enabledBorders());
     }
-    DialogShadows::self()->addWindow(this, m_frameSvgItem->enabledBorders());
+
+    KWindowEffects::SlideFromLocation slideLocation = KWindowEffects::NoEdge;
+
+    switch (m_location) {
+    case Plasma::Types::TopEdge:
+        slideLocation = KWindowEffects::TopEdge;
+        break;
+    case Plasma::Types::LeftEdge:
+        slideLocation = KWindowEffects::LeftEdge;
+        break;
+    case Plasma::Types::RightEdge:
+        slideLocation = KWindowEffects::RightEdge;
+        break;
+    case Plasma::Types::BottomEdge:
+        slideLocation = KWindowEffects::BottomEdge;
+        break;
+    //no edge, no slide
+    default:
+        break;        
+    }
+
+    KWindowEffects::slideWindow(winId(), slideLocation, -1);
     QQuickWindow::setVisible(visible);
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]