[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [amarok] src/context/engines/wikipedia: Fix crashes on track change (both with Phonon-GStreamer
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-05-09 8:41:47
Message-ID: 7731274.fJVl9nZAA6 () edgy
[Download RAW message or body]


On 8. 5. 2013 Mark Kretschmann wrote:
> Git commit d13bd61842627ffb2382b5d59a020ea7a5124ca5 by Mark Kretschmann.
> Committed on 08/05/2013 at 12:29.
> Pushed by markey into branch 'master'.
> 
> Fix crashes on track change (both with Phonon-GStreamer and Phonon-VLC).
> 
> What happened:
> 
> The Wikipedia applet uses QtWebKit for HTML rendering. On
> Linux, QtWebKit uses GStreamer for media playback. Turns out that this
> crashes with a high probability whenever an <audio> tag is present on a web
> page. As music artists' pages often contain audio snippets in Vorbis
> format, it crashed a lot when Amarok's applet rendered a page.
> 
> The fix:
> 
> Removing all audio tags from Wikipedia pages before rendering them in our
> applet. Of course, the real fix would have to be done upstream. But until
> that happens, our workaround here fixes a shitload of crashes.
> 
> We might want to do a 2.7.1 release for Linux, with this patch.
> 
> CCMAIL: amarok-devel@kde.org

Yay! But I guess there's a reported bug fixed by this?

	Matěj
[prev in list] [next in list] [prev in thread] [next in thread]