[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs] kioslave/http/kcookiejar: Initialise the mCrossDomain member variable in the cookies
From:       Thiago Macieira <thiago.macieira () intel ! com>
Date:       2013-01-18 11:36:29
Message-ID: 2289242.pbsa1To9zP () tjmaciei-mobl2
[Download RAW message or body]


On sexta-feira, 18 de janeiro de 2013 11.26.21, Albert Astals Cid wrote:
> --- El vie, 18/1/13, Thiago Macieira <thiago.macieira@intel.com> escribió:
> > Initialise the mCrossDomain member variable in the cookies
> > 
> > For several months now, all my cookies would be forgotten
> > after a kded
> > restart. After debugging the problem, turns out that
> > mCrossDomain was
> > of value 127, which makes no sense for a boolean.
> > 
> > This variable has been present since 2002, which means that
> > the
> > "reject cross domain cookies" feature has been broken for 10
> > years and
> > 8 months.
> 
> Are you planning the backport of this to KDE/4.10 or 6 months more don't
> mean much when it's been broken 10 years? :D

If you're going to round, at least round to the nearest: 11 years :-)

The feature is not enabled by default, so most users aren't affected.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]