[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [nepomuk-core] services/fileindexer: make status update correct
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2012-12-16 21:57:03
Message-ID: CAOPTMKCsg54FQ6Rvt6NG5wGsyH_N5+H4Mbq1GjauKx1CgimG9g () mail ! gmail ! com
[Download RAW message or body]

On Mon, Dec 17, 2012 at 2:36 AM, Weng Xuetian <wengxt@gmail.com> wrote:

> Git commit aae885c207877cbad087ad49c3f547127d359c62 by Weng Xuetian.
> Committed on 16/12/2012 at 21:56.
> Pushed by xuetianweng into branch 'master'.
>
> make status update correct
>
> M  +2    -1    services/fileindexer/fileindexingqueue.cpp
>
>
> http://commits.kde.org/nepomuk-core/aae885c207877cbad087ad49c3f547127d359c62
>
> diff --git a/services/fileindexer/fileindexingqueue.cpp
> b/services/fileindexer/fileindexingqueue.cpp
> index d7b46bf..7f5d20f 100644
> --- a/services/fileindexer/fileindexingqueue.cpp
> +++ b/services/fileindexer/fileindexingqueue.cpp
> @@ -87,8 +87,9 @@ void FileIndexingQueue::slotFinishedIndexingFile(KJob*
> job)
>          kDebug() << job->errorString();
>      }
>
> -    emit endIndexingFile( m_currentUrl );
> +    QUrl url = m_currentUrl;
>      m_currentUrl.clear();
> +    emit endIndexingFile( url );
>

I don't understand why this was done. How does it make a difference if
m_currentUrl has its current value when calling endIndexingFile? I have let
it have a value just in case someone wishes to call currentUrl() in one of
the slots connected to endIndexingFile.

     if( m_fileQueue.isEmpty() ) {
>          fillQueue();
>      }
>
>

[Attachment #3 (text/html)]

<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 17, 2012 at \
2:36 AM, Weng Xuetian <span dir="ltr">&lt;<a href="mailto:wengxt@gmail.com" \
target="_blank">wengxt@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Git commit aae885c207877cbad087ad49c3f547127d359c62 by Weng \
Xuetian.<br> Committed on 16/12/2012 at 21:56.<br>
Pushed by xuetianweng into branch &#39;master&#39;.<br>
<br>
make status update correct<br>
<br>
M  +2    -1    services/fileindexer/fileindexingqueue.cpp<br>
<br>
<a href="http://commits.kde.org/nepomuk-core/aae885c207877cbad087ad49c3f547127d359c62" \
target="_blank">http://commits.kde.org/nepomuk-core/aae885c207877cbad087ad49c3f547127d359c62</a><br>
 <br>
diff --git a/services/fileindexer/fileindexingqueue.cpp \
b/services/fileindexer/fileindexingqueue.cpp<br> index d7b46bf..7f5d20f 100644<br>
--- a/services/fileindexer/fileindexingqueue.cpp<br>
+++ b/services/fileindexer/fileindexingqueue.cpp<br>
@@ -87,8 +87,9 @@ void FileIndexingQueue::slotFinishedIndexingFile(KJob* job)<br>
         kDebug() &lt;&lt; job-&gt;errorString();<br>
     }<br>
<br>
-    emit endIndexingFile( m_currentUrl );<br>
+    QUrl url = m_currentUrl;<br>
     m_currentUrl.clear();<br>
+    emit endIndexingFile( url );<br></blockquote><div><br>I don&#39;t understand why \
this was done. How does it make a difference if m_currentUrl has its current value \
when calling endIndexingFile? I have let it have a value just in case someone wishes \
to call currentUrl() in one of the slots connected to endIndexingFile.<br> \
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">  if( m_fileQueue.isEmpty() ) {<br>
         fillQueue();<br>
     }<br>
<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]