From kde-commits  Sun Dec 16 21:57:03 2012
From: Vishesh Handa <handa.vish () gmail ! com>
Date: Sun, 16 Dec 2012 21:57:03 +0000
To: kde-commits
Subject: Re: [nepomuk-core] services/fileindexer: make status update correct
Message-Id: <CAOPTMKCsg54FQ6Rvt6NG5wGsyH_N5+H4Mbq1GjauKx1CgimG9g () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-commits&m=135569502312656
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--f46d04447f23acf6ec04d0ff4f5c"

--f46d04447f23acf6ec04d0ff4f5c
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Dec 17, 2012 at 2:36 AM, Weng Xuetian <wengxt@gmail.com> wrote:

> Git commit aae885c207877cbad087ad49c3f547127d359c62 by Weng Xuetian.
> Committed on 16/12/2012 at 21:56.
> Pushed by xuetianweng into branch 'master'.
>
> make status update correct
>
> M  +2    -1    services/fileindexer/fileindexingqueue.cpp
>
>
> http://commits.kde.org/nepomuk-core/aae885c207877cbad087ad49c3f547127d359c62
>
> diff --git a/services/fileindexer/fileindexingqueue.cpp
> b/services/fileindexer/fileindexingqueue.cpp
> index d7b46bf..7f5d20f 100644
> --- a/services/fileindexer/fileindexingqueue.cpp
> +++ b/services/fileindexer/fileindexingqueue.cpp
> @@ -87,8 +87,9 @@ void FileIndexingQueue::slotFinishedIndexingFile(KJob*
> job)
>          kDebug() << job->errorString();
>      }
>
> -    emit endIndexingFile( m_currentUrl );
> +    QUrl url = m_currentUrl;
>      m_currentUrl.clear();
> +    emit endIndexingFile( url );
>

I don't understand why this was done. How does it make a difference if
m_currentUrl has its current value when calling endIndexingFile? I have let
it have a value just in case someone wishes to call currentUrl() in one of
the slots connected to endIndexingFile.

     if( m_fileQueue.isEmpty() ) {
>          fillQueue();
>      }
>
>

--f46d04447f23acf6ec04d0ff4f5c
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Mon, D=
ec 17, 2012 at 2:36 AM, Weng Xuetian <span dir=3D"ltr">&lt;<a href=3D"mailt=
o:wengxt@gmail.com" target=3D"_blank">wengxt@gmail.com</a>&gt;</span> wrote=
:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-le=
ft:1px #ccc solid;padding-left:1ex">
Git commit aae885c207877cbad087ad49c3f547127d359c62 by Weng Xuetian.<br>
Committed on 16/12/2012 at 21:56.<br>
Pushed by xuetianweng into branch &#39;master&#39;.<br>
<br>
make status update correct<br>
<br>
M =A0+2 =A0 =A0-1 =A0 =A0services/fileindexer/fileindexingqueue.cpp<br>
<br>
<a href=3D"http://commits.kde.org/nepomuk-core/aae885c207877cbad087ad49c3f5=
47127d359c62" target=3D"_blank">http://commits.kde.org/nepomuk-core/aae885c=
207877cbad087ad49c3f547127d359c62</a><br>
<br>
diff --git a/services/fileindexer/fileindexingqueue.cpp b/services/fileinde=
xer/fileindexingqueue.cpp<br>
index d7b46bf..7f5d20f 100644<br>
--- a/services/fileindexer/fileindexingqueue.cpp<br>
+++ b/services/fileindexer/fileindexingqueue.cpp<br>
@@ -87,8 +87,9 @@ void FileIndexingQueue::slotFinishedIndexingFile(KJob* jo=
b)<br>
=A0 =A0 =A0 =A0 =A0kDebug() &lt;&lt; job-&gt;errorString();<br>
=A0 =A0 =A0}<br>
<br>
- =A0 =A0emit endIndexingFile( m_currentUrl );<br>
+ =A0 =A0QUrl url =3D m_currentUrl;<br>
=A0 =A0 =A0m_currentUrl.clear();<br>
+ =A0 =A0emit endIndexingFile( url );<br></blockquote><div><br>I don&#39;t =
understand why this was done. How does it make a difference if m_currentUrl=
 has its current value when calling endIndexingFile? I have let it have a v=
alue just in case someone wishes to call currentUrl() in one of the slots c=
onnected to endIndexingFile.<br>
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
=A0 =A0 =A0if( m_fileQueue.isEmpty() ) {<br>
=A0 =A0 =A0 =A0 =A0fillQueue();<br>
=A0 =A0 =A0}<br>
<br>
</blockquote></div><br></div>

--f46d04447f23acf6ec04d0ff4f5c--