[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Fwd: [kdelibs/frameworks] kio: Implement TODO: make SessionData completely private
From:       Dawit A <adawit () kde ! org>
Date:       2012-11-21 17:12:30
Message-ID: CALa28R6e-K_aGaBF+q5xOJKw7_0c0N3Xnb_z2cTAoQD2pn+iiA () mail ! gmail ! com
[Download RAW message or body]

On Wednesday 21 November 2012 11:23:38 Dawit A wrote:
> Actually SlaveConfig itself should also be made private, but some apps
> might already be using it directly which is unfortunate. It was not really
> intended for external use.

http://lxr.kde.org/ident?i=SlaveConfig shows only two uses outside of
kdelibs:

        /extragear/utils/krusader/krusader/GUI/krremoteencodingmenu.cpp,
line 94
        /kde/kde-baseapps/dolphin/src/views/dolphinremoteencoding.cpp, line
135

Can you recommend how these two apps should do what they're doing? :)
Seems that in both cases it's about the Charset metadata.

--
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

[Attachment #3 (text/html)]

<div class="gmail_quote"><div class="im">On Wednesday 21 November 2012 \
11:23:38 Dawit A wrote:<br> &gt; Actually SlaveConfig itself should also be \
made private, but some apps<br> &gt; might already be using it directly \
which is unfortunate. It was not really<br> &gt; intended for external \
use.<br> <br>
</div><a href="http://lxr.kde.org/ident?i=SlaveConfig" \
target="_blank">http://lxr.kde.org/ident?i=SlaveConfig</a> shows only two \
uses outside of kdelibs:<br> <br>
            /extragear/utils/krusader/krusader/GUI/krremoteencodingmenu.cpp, \
                line 94<br>
            /kde/kde-baseapps/dolphin/src/views/dolphinremoteencoding.cpp, \
line 135<br> <br>
Can you recommend how these two apps should do what they&#39;re doing? \
:)<br> Seems that in both cases it&#39;s about the Charset metadata.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
David Faure, <a href="mailto:faure@kde.org">faure@kde.org</a>, <a \
href="http://www.davidfaure.fr" \
target="_blank">http://www.davidfaure.fr</a><br> Working on KDE, in \
particular KDE Frameworks 5<br> <br>
</font></span></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]