From kde-commits Wed Nov 21 17:12:30 2012 From: Dawit A Date: Wed, 21 Nov 2012 17:12:30 +0000 To: kde-commits Subject: Fwd: [kdelibs/frameworks] kio: Implement TODO: make SessionData completely private Message-Id: X-MARC-Message: https://marc.info/?l=kde-commits&m=135351800120928 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--14dae93999690438ba04cf047782" --14dae93999690438ba04cf047782 Content-Type: text/plain; charset=UTF-8 On Wednesday 21 November 2012 11:23:38 Dawit A wrote: > Actually SlaveConfig itself should also be made private, but some apps > might already be using it directly which is unfortunate. It was not really > intended for external use. http://lxr.kde.org/ident?i=SlaveConfig shows only two uses outside of kdelibs: /extragear/utils/krusader/krusader/GUI/krremoteencodingmenu.cpp, line 94 /kde/kde-baseapps/dolphin/src/views/dolphinremoteencoding.cpp, line 135 Can you recommend how these two apps should do what they're doing? :) Seems that in both cases it's about the Charset metadata. -- David Faure, faure@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 --14dae93999690438ba04cf047782 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wednesday 21 November 2012 = 11:23:38 Dawit A wrote:
> Actually SlaveConfig itself should also be made private, but some apps=
> might already be using it directly which is unfortunate. It was not re= ally
> intended for external use.

http://lxr.kde.org/ident?i=3DSlaveConfig shows only two uses outside = of kdelibs:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 /extragear/utils/krusader/krusader/GUI/krremote= encodingmenu.cpp, line 94
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /kde/kde-baseapps/dolphin/src/views/dolphinremo= teencoding.cpp, line 135

Can you recommend how these two apps should do what they're doing? :) Seems that in both cases it's about the Charset metadata.

--
David Faure, faure@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5


--14dae93999690438ba04cf047782--