[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: www/sites/www/applications
From:       Wolfgang Rohdewald <wolfgang () rohdewald ! de>
Date:       2012-09-15 2:56:06
Message-ID: 2393263.KY2czlxViA () i5
[Download RAW message or body]

Am Mittwoch, 12. September 2012, 22:40:21 schrieb Albert Astals Cid:
> El Dimecres, 12 de setembre de 2012, a les 22:18:11, Wolfgang Rohdewald va 
> escriure:
> > SVN commit 1316122 by wrohdewald:
> > 
> > games overview: also rename internal game names
> 
> Are you sure you want to rename those internal names? You probbly just broke 
> lost of incoming urls.

if kbattleship / ktron have trademark problems, shouldn't rather
the incoming url's be fixed to the non-trademarked names?


but I tried to not rename them:

The problem is the code loading the icons.

in the game overview, the name is as defined in applications/index.json.
So if I put kbattleship there, icons/kbattleship_22.png is loaded.
in the specific game page, it is the name, lowercased and without spaces.
So "Naval Battle" loads icons/navalbattle_22.png

that is why I had to rename the internal game name in index.json.

I cannot see how not to rename internal game names without either
duplicating data files (icons, apps/) or fixing the php code such that it
always builds paths from the same data source, namely as in index.json
(a job I would not want to do, I know nothing about php)

-- 
Wolfgang
[prev in list] [next in list] [prev in thread] [next in thread]