[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [rekonq] src: Get sure rekonq makes use of djvu plugin
From:       Dawit A <adawit () kde ! org>
Date:       2012-08-15 20:41:25
Message-ID: CALa28R4JqQk-jDAVf7QmtzcGnycATTd7VU2C7ZKz9Bv79Sftsw () mail ! gmail ! com
[Download RAW message or body]

On Tue, Aug 14, 2012 at 11:15 AM, Andrea Diamantini <adjam7@gmail.com>wrote:

> Git commit 3b7a1ffae0ae9e5fd0c1dd238434e0bf312fa6ad by Andrea Diamantini.
> Committed on 14/08/2012 at 10:57.
> Pushed by adjam into branch 'master'.
>
> Get sure rekonq makes use of djvu plugin
>
> Also, clean up mimetype detection, following kdewebkit.
>
> I tried implementing this using the protected excludeMimeType in
> kwebpluginfactory, but I fear it has to be declared virtual to let
> the trick work. Isn't it?
> BUG: 304562
> CCMAIL: adawit@kde.org



Well, that function could not have been made virtual because it would break
BIC. However, we can always add a protected function that accepts
mime-types to be excluded and change the "excludedMimeType" function to
take those into account.

[Attachment #3 (text/html)]

<br><br><div class="gmail_quote">On Tue, Aug 14, 2012 at 11:15 AM, Andrea Diamantini \
<span dir="ltr">&lt;<a href="mailto:adjam7@gmail.com" \
target="_blank">adjam7@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Git commit 3b7a1ffae0ae9e5fd0c1dd238434e0bf312fa6ad by Andrea Diamantini.<br>
Committed on 14/08/2012 at 10:57.<br>
Pushed by adjam into branch &#39;master&#39;.<br>
<br>
Get sure rekonq makes use of djvu plugin<br>
<br>
Also, clean up mimetype detection, following kdewebkit.<br>
<br>
I tried implementing this using the protected excludeMimeType in<br>
kwebpluginfactory, but I fear it has to be declared virtual to let<br>
the trick work. Isn&#39;t it?<br>
BUG: 304562<br>
CCMAIL: <a href="mailto:adawit@kde.org">adawit@kde.org</a></blockquote><div><br></div><div><br></div><div>Well, \
that function could not have been made virtual because it would break BIC. However, \
we can always add a protected function that accepts mime-types to be excluded and \
change the &quot;excludedMimeType&quot; function to take those into account.</div>

</div>



[prev in list] [next in list] [prev in thread] [next in thread]