From kde-commits Wed Aug 15 20:41:25 2012 From: Dawit A Date: Wed, 15 Aug 2012 20:41:25 +0000 To: kde-commits Subject: Re: [rekonq] src: Get sure rekonq makes use of djvu plugin Message-Id: X-MARC-Message: https://marc.info/?l=kde-commits&m=134506362330495 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--f46d04446bbdbc171d04c753f51b" --f46d04446bbdbc171d04c753f51b Content-Type: text/plain; charset=UTF-8 On Tue, Aug 14, 2012 at 11:15 AM, Andrea Diamantini wrote: > Git commit 3b7a1ffae0ae9e5fd0c1dd238434e0bf312fa6ad by Andrea Diamantini. > Committed on 14/08/2012 at 10:57. > Pushed by adjam into branch 'master'. > > Get sure rekonq makes use of djvu plugin > > Also, clean up mimetype detection, following kdewebkit. > > I tried implementing this using the protected excludeMimeType in > kwebpluginfactory, but I fear it has to be declared virtual to let > the trick work. Isn't it? > BUG: 304562 > CCMAIL: adawit@kde.org Well, that function could not have been made virtual because it would break BIC. However, we can always add a protected function that accepts mime-types to be excluded and change the "excludedMimeType" function to take those into account. --f46d04446bbdbc171d04c753f51b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Tue, Aug 14, 2012 at 11:15 AM, Andrea= Diamantini <adjam7@gmail.com> wrote:
Git commit 3b7a1ffae0ae9e5fd0c1dd238434e0bf312fa6ad by Andrea Diamantini. Committed on 14/08/2012 at 10:57.
Pushed by adjam into branch 'master'.

Get sure rekonq makes use of djvu plugin

Also, clean up mimetype detection, following kdewebkit.

I tried implementing this using the protected excludeMimeType in
kwebpluginfactory, but I fear it has to be declared virtual to let
the trick work. Isn't it?
BUG: 304562
CCMAIL: adawit@kde.org


Well, that function could not have been ma= de virtual because it would break BIC. However, we can always add a protect= ed function that accepts mime-types to be excluded and change the "exc= ludedMimeType" function to take those into account.
--f46d04446bbdbc171d04c753f51b--