'Re: [plasma-mediacenter/PMC/0.9] shells/newshell: OpenGL enabled by default makes more sense. People'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [plasma-mediacenter/PMC/0.9] shells/newshell: OpenGL enabled by default makes more sense. People
From:       "Lamarque V. Souza" <lamarque () kde ! org>
Date:       2012-05-14 14:52:53
Message-ID: 201205141152.53763.lamarque () kde ! org
[Download RAW message or body]

Em Sunday 13 May 2012, Shantanu Tushar escreveu:
> Git commit 2efe59b7be35c5ef019064647435d6cf60959ffb by Shantanu Tushar.
> Committed on 13/05/2012 at 10:11.
> Pushed by shantanu into branch 'PMC/0.9'.
> 
> OpenGL enabled by default makes more sense. People on desktops etc had
> bad video performance if they didn't pass --opengl.

	Have you tested my patch on the desktop? Xv is supposed to work better 
than opengl on Linux.
 
> CCMAIL: lamarque@kde.org
> 
> M  +1    -1    shells/newshell/main.cpp
> M  +1    -1    shells/newshell/mainwindow.cpp
> 
> http://commits.kde.org/plasma-mediacenter/2efe59b7be35c5ef019064647435d6cf6
> 0959ffb
> 
> diff --git a/shells/newshell/main.cpp b/shells/newshell/main.cpp
> index f4ccb88..97cbb82 100644
> --- a/shells/newshell/main.cpp
> +++ b/shells/newshell/main.cpp
> @@ -50,7 +50,7 @@ int main(int argc, char *argv[])
>      KCmdLineArgs::init(argc, argv, &aboutData);
>      KCmdLineOptions options;
>      options.add("fullscreen", ki18n("Starts Plasma Media Center in
> fullscreen mode (the default)")); -    options.add("opengl", ki18n("Starts
> Plasma Media Center with OpenGL support")); +   
> options.add("disable-opengl", ki18n("Starts Plasma Media Center with
> OpenGL support")); KCmdLineArgs::addCmdLineOptions(options);
> 
>      KApplication app;
> diff --git a/shells/newshell/mainwindow.cpp
> b/shells/newshell/mainwindow.cpp index 26f7b1f..46c900e 100644
> --- a/shells/newshell/mainwindow.cpp
> +++ b/shells/newshell/mainwindow.cpp
> @@ -44,7 +44,7 @@ MainWindow::MainWindow(QWidget *parent) :
> KMainWindow(parent)
> 
>      QDeclarativeView *view = new QDeclarativeView(this);
> 
> -    if (args->isSet("opengl")) {
> +    if (!args->isSet("disable-opengl")) {
>          QGLWidget *glWidget = new QGLWidget;
>          glWidget->setAutoFillBackground(false);
>          view->setViewport(glWidget);


-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br

[Attachment #3 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Tahoma'; font-size:12pt; font-weight:400; \
font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Em Sunday \
13 May 2012, Shantanu Tushar escreveu:</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; Git commit \
2efe59b7be35c5ef019064647435d6cf60959ffb by Shantanu Tushar.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Committed on 13/05/2012 \
at 10:11.</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Pushed \
by shantanu into branch 'PMC/0.9'.</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; OpenGL enabled by default makes more sense. People on \
desktops etc had</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; bad \
video performance if they didn't pass --opengl.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">	Have you tested my patch on \
the desktop? Xv is supposed to work better than opengl on Linux.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; CCMAIL: \
lamarque@kde.org</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; M  +1    -1    \
shells/newshell/main.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; M  +1    -1    shells/newshell/mainwindow.cpp</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; \
http://commits.kde.org/plasma-mediacenter/2efe59b7be35c5ef019064647435d6cf6</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; 0959ffb</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; diff --git \
a/shells/newshell/main.cpp b/shells/newshell/main.cpp</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; index f4ccb88..97cbb82 100644</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; --- \
a/shells/newshell/main.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; +++ b/shells/newshell/main.cpp</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; @@ -50,7 +50,7 @@ int main(int argc, char \
*argv[])</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;      \
KCmdLineArgs::init(argc, argv, &amp;aboutData);</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt;      KCmdLineOptions options;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;      \
options.add(&quot;fullscreen&quot;, ki18n(&quot;Starts Plasma Media Center in</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; fullscreen mode (the \
default)&quot;)); -    options.add(&quot;opengl&quot;, ki18n(&quot;Starts</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; Plasma Media Center with \
OpenGL support&quot;)); +   </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; options.add(&quot;disable-opengl&quot;, ki18n(&quot;Starts \
Plasma Media Center with</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; OpenGL support&quot;)); \
KCmdLineArgs::addCmdLineOptions(options);</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt;      KApplication app;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; diff --git \
a/shells/newshell/mainwindow.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; b/shells/newshell/mainwindow.cpp index 26f7b1f..46c900e \
100644</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; --- \
a/shells/newshell/mainwindow.cpp</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; +++ b/shells/newshell/mainwindow.cpp</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; @@ -44,7 +44,7 @@ \
MainWindow::MainWindow(QWidget *parent) :</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; KMainWindow(parent)</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;      QDeclarativeView \
*view = new QDeclarativeView(this);</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">&gt; -    if (args-&gt;isSet(&quot;opengl&quot;)) {</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; +    if \
(!args-&gt;isSet(&quot;disable-opengl&quot;)) {</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt;          QGLWidget *glWidget = new \
QGLWidget;</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt;        \
glWidget-&gt;setAutoFillBackground(false);</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt;          view-&gt;setViewport(glWidget);</p> \
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> \
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">-- </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Lamarque V. Souza</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">KDE's Network Management \
maintainer</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">http://planetkde.org/pt-br</p></body></html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic