--Boundary-01=_FxRsP1U4Iflf1uF
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: 7bit
Em Sunday 13 May 2012, Shantanu Tushar escreveu:
> Git commit 2efe59b7be35c5ef019064647435d6cf60959ffb by Shantanu Tushar.
> Committed on 13/05/2012 at 10:11.
> Pushed by shantanu into branch 'PMC/0.9'.
>
> OpenGL enabled by default makes more sense. People on desktops etc had
> bad video performance if they didn't pass --opengl.
Have you tested my patch on the desktop? Xv is supposed to work better
than opengl on Linux.
> CCMAIL: lamarque@kde.org
>
> M +1 -1 shells/newshell/main.cpp
> M +1 -1 shells/newshell/mainwindow.cpp
>
> http://commits.kde.org/plasma-mediacenter/2efe59b7be35c5ef019064647435d6cf6
> 0959ffb
>
> diff --git a/shells/newshell/main.cpp b/shells/newshell/main.cpp
> index f4ccb88..97cbb82 100644
> --- a/shells/newshell/main.cpp
> +++ b/shells/newshell/main.cpp
> @@ -50,7 +50,7 @@ int main(int argc, char *argv[])
> KCmdLineArgs::init(argc, argv, &aboutData);
> KCmdLineOptions options;
> options.add("fullscreen", ki18n("Starts Plasma Media Center in
> fullscreen mode (the default)")); - options.add("opengl", ki18n("Starts
> Plasma Media Center with OpenGL support")); +
> options.add("disable-opengl", ki18n("Starts Plasma Media Center with
> OpenGL support")); KCmdLineArgs::addCmdLineOptions(options);
>
> KApplication app;
> diff --git a/shells/newshell/mainwindow.cpp
> b/shells/newshell/mainwindow.cpp index 26f7b1f..46c900e 100644
> --- a/shells/newshell/mainwindow.cpp
> +++ b/shells/newshell/mainwindow.cpp
> @@ -44,7 +44,7 @@ MainWindow::MainWindow(QWidget *parent) :
> KMainWindow(parent)
>
> QDeclarativeView *view = new QDeclarativeView(this);
>
> - if (args->isSet("opengl")) {
> + if (!args->isSet("disable-opengl")) {
> QGLWidget *glWidget = new QGLWidget;
> glWidget->setAutoFillBackground(false);
> view->setViewport(glWidget);
--
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
--Boundary-01=_FxRsP1U4Iflf1uF
Content-Type: text/html;
charset="utf-8"
Content-Transfer-Encoding: 7bit
Em Sunday 13 May 2012, Shantanu Tushar escreveu:
> Git commit 2efe59b7be35c5ef019064647435d6cf60959ffb by Shantanu Tushar.
> Committed on 13/05/2012 at 10:11.
> Pushed by shantanu into branch 'PMC/0.9'.
>
> OpenGL enabled by default makes more sense. People on desktops etc had
> bad video performance if they didn't pass --opengl.
Have you tested my patch on the desktop? Xv is supposed to work better than opengl on Linux.
> CCMAIL: lamarque@kde.org
>
> M +1 -1 shells/newshell/main.cpp
> M +1 -1 shells/newshell/mainwindow.cpp
>
> http://commits.kde.org/plasma-mediacenter/2efe59b7be35c5ef019064647435d6cf6
> 0959ffb
>
> diff --git a/shells/newshell/main.cpp b/shells/newshell/main.cpp
> index f4ccb88..97cbb82 100644
> --- a/shells/newshell/main.cpp
> +++ b/shells/newshell/main.cpp
> @@ -50,7 +50,7 @@ int main(int argc, char *argv[])
> KCmdLineArgs::init(argc, argv, &aboutData);
> KCmdLineOptions options;
> options.add("fullscreen", ki18n("Starts Plasma Media Center in
> fullscreen mode (the default)")); - options.add("opengl", ki18n("Starts
> Plasma Media Center with OpenGL support")); +
> options.add("disable-opengl", ki18n("Starts Plasma Media Center with
> OpenGL support")); KCmdLineArgs::addCmdLineOptions(options);
>
> KApplication app;
> diff --git a/shells/newshell/mainwindow.cpp
> b/shells/newshell/mainwindow.cpp index 26f7b1f..46c900e 100644
> --- a/shells/newshell/mainwindow.cpp
> +++ b/shells/newshell/mainwindow.cpp
> @@ -44,7 +44,7 @@ MainWindow::MainWindow(QWidget *parent) :
> KMainWindow(parent)
>
> QDeclarativeView *view = new QDeclarativeView(this);
>
> - if (args->isSet("opengl")) {
> + if (!args->isSet("disable-opengl")) {
> QGLWidget *glWidget = new QGLWidget;
> glWidget->setAutoFillBackground(false);
> view->setViewport(glWidget);
--
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
--Boundary-01=_FxRsP1U4Iflf1uF--