[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bnetworkmanagement=5D_libs/internals=3A_Do_not_save_?=
From:       "Lamarque V.Souza" <lamarque () gmail ! com>
Date:       2011-05-01 1:18:08
Message-ID: 20110501011808.A7C76A60AE () git ! kde ! org
[Download RAW message or body]

Git commit aabca85cce31ce40114c62a783fd7480383ae03e by Lamarque V. Souza.
Committed on 01/05/2011 at 02:47.
Pushed by lvsouza into branch 'master'.

Do not save PIN in wallet or configuration file. PIN is now one-time
only.

CCBUG: 264083

M  +4    -0    libs/internals/connectionpersistence.cpp     
M  +4    -2    libs/internals/settings/gsmpersistence.cpp     

http://commits.kde.org/networkmanagement/aabca85cce31ce40114c62a783fd7480383ae03e

diff --git a/libs/internals/connectionpersistence.cpp b/libs/internals/connectionpersistence.cpp
index eb6b2c7..0c3eebe 100644
--- a/libs/internals/connectionpersistence.cpp
+++ b/libs/internals/connectionpersistence.cpp
@@ -182,6 +182,10 @@ void ConnectionPersistence::save()
             foreach (Setting * setting, m_connection->settings()) {
                 SettingPersistence * sp = persistenceFor(setting);
                 QMap<QString,QString> secrets = sp->secrets();
+
+                // Do not save pin.
+                secrets.take("pin");
+
                 if (!secrets.isEmpty()) {
                     wallet->writeMap(walletKeyFor(setting), secrets);
                 }
diff --git a/libs/internals/settings/gsmpersistence.cpp b/libs/internals/settings/gsmpersistence.cpp
index fc94b01..3a6dfb6 100644
--- a/libs/internals/settings/gsmpersistence.cpp
+++ b/libs/internals/settings/gsmpersistence.cpp
@@ -27,7 +27,8 @@ void GsmPersistence::load()
   // SECRETS
   if (m_storageMode == ConnectionPersistence::PlainText) {
     setting->setPassword(m_config->readEntry("password", ""));
-    setting->setPin(m_config->readEntry("pin", ""));
+    // Do not read pin.
+    //setting->setPin(m_config->readEntry("pin", ""));
     setting->setSecretsAvailable(true);
   }
   setting->setInitialized();
@@ -45,7 +46,8 @@ void GsmPersistence::save()
   // SECRET
   if (m_storageMode == ConnectionPersistence::PlainText) {
     m_config->writeEntry("password", setting->password());
-    m_config->writeEntry("pin", setting->pin());
+    // Do not save pin.
+    //m_config->writeEntry("pin", setting->pin());
   }
 }
 

[prev in list] [next in list] [prev in thread] [next in thread]