[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/dialogs
From:       David Faure <faure () kde ! org>
Date:       2010-11-28 16:45:32
Message-ID: 201011281745.33319.faure () kde ! org
[Download RAW message or body]

On Saturday 27 November 2010, Teo Mrnjavac wrote:
> SVN commit 1201489 by mrnjavac:
> 
> Fix wrong email link being launched.
> CCBUG:258085
> 
>  M  +5 -1      kaboutapplicationpersonlistdelegate_p.cpp
> 
> 
> ---
> trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
> #1201488:1201489 @@ -257,8 +257,12 @@
>  void KAboutApplicationPersonListDelegate::launchUrl( QAction *action )
> const {
>      QString url = action->data().toString();
> -    if( !url.isEmpty() )
> +    if( !url.isEmpty() ) {
> +        if( url.startsWith( "mailto:" ) )
> +            KToolInvocation::invokeMailer( url.mid( 7 ) );

InvokeMailer takes a const KUrl& mailtoURL, so there is no need for the 
.mid(7), it even looks wrong to me.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]