[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/dialogs
From:       Teo Mrnjavac <teo () kde ! org>
Date:       2010-11-28 9:22:54
Message-ID: 20101128092254.622DDAC8A3 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1201556 by mrnjavac:

No need to waste a GET in Attica::ProviderManager::loadDefaultProviders() if there \
are no OCS usernames in the persons list.

 M  +6 -0      kaboutapplicationpersonmodel_p.cpp  


--- trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp \
#1201555:1201556 @@ -41,9 +41,14 @@
     if( m_providerUrl.isEmpty() )
         m_providerUrl = QString( "https://api.opendesktop.org/v1/" );
 
+    bool hasOcsUsernames = 0;
     for( QList< KAboutPerson >::const_iterator it = personList.begin(); it != \
personList.end(); ++it )  {
         KAboutPerson person = *it;
+
+        if( !person.ocsUsername().isEmpty() )
+            hasOcsUsernames = 1;
+
         KAboutApplicationPersonProfile profile =
                 KAboutApplicationPersonProfile( person.name(),
                                                 person.task(),
@@ -55,6 +60,7 @@
 #ifdef HAVE_ATTICA
     connect( &m_providerManager, SIGNAL( defaultProvidersLoaded() ),
              SLOT( onProvidersLoaded() ) );
+    if( hasOcsUsernames )
     m_providerManager.loadDefaultProviders();
 #endif //HAVE_ATTICA
 }


[prev in list] [next in list] [prev in thread] [next in thread]