[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/solid/solid
From:       Lukáš_Tinkl <ltinkl () redhat ! com>
Date:       2010-11-16 16:20:52
Message-ID: 201011161720.52438.ltinkl () redhat ! com
[Download RAW message or body]

Dne Út 16. listopadu 2010 16:31:28 jste napsal(a): > On Tuesday 16 November 
2010 09:58:16 Lukáš Tinkl wrote:
> > Dne Út 16. listopadu 2010 00:44:02 Raphael Kubo da Costa napsal(a):
> > > SVN commit 1197469 by rkcosta:
> > > 
> > > Only build the udisks backend on Linux.
> > > 
> > > Recent commits added a hard dependency on linux_dvd_rw_utils.{c,h}
> > > that cannot be #ifdef'ed with Q_OS_LINUX. Until that is fixed, we need
> > > to skip the udisks backend for kdelibs to build again on OpenSolaris,
> > > FreeBSD and other non-Linux Unixes.
> > > 
> > > CCMAIL: lukas@kde.org
> > > CCMAIL: kde-hardware-devel@kde.org
> > 
> > Why not add a simple "if not linux" cmake switch?
> 
> Sorry, I didn't understand what you meant. Do you mean something like
> 
>   if (not on linux)
>     do_something
>   endif (not on linux)
> 
> instead of
> 
>   if (on linux)
>     add udisks stuff
>   endif (on linux)
> 
> ?

Yes, of course, I meant "if on linux" :) That way the udisks backend gets only 
added for Linux and doesn't fail on other Unixes

-- 
Lukáš Tinkl <ltinkl@redhat.com>
Software Engineer - Base Operating Systems Brno
KDE developer <lukas@kde.org>
Red Hat Inc.                               http://cz.redhat.com

[prev in list] [next in list] [prev in thread] [next in thread]