[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/solid/solid
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2010-11-16 15:31:28
Message-ID: 201011161331.29006.kubito () gmail ! com
[Download RAW message or body]

On Tuesday 16 November 2010 09:58:16 Lukáš Tinkl wrote:
> Dne Út 16. listopadu 2010 00:44:02 Raphael Kubo da Costa napsal(a):
> > SVN commit 1197469 by rkcosta:
> > 
> > Only build the udisks backend on Linux.
> > 
> > Recent commits added a hard dependency on linux_dvd_rw_utils.{c,h}
> > that cannot be #ifdef'ed with Q_OS_LINUX. Until that is fixed, we need
> > to skip the udisks backend for kdelibs to build again on OpenSolaris,
> > FreeBSD and other non-Linux Unixes.
> > 
> > CCMAIL: lukas@kde.org
> > CCMAIL: kde-hardware-devel@kde.org
> 
> Why not add a simple "if not linux" cmake switch?

Sorry, I didn't understand what you meant. Do you mean something like

  if (not on linux)
    do_something
  endif (not on linux)

instead of

  if (on linux)
    add udisks stuff
  endif (on linux)

?

[prev in list] [next in list] [prev in thread] [next in thread]