[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore
From:       John Layt <john () layt ! net>
Date:       2010-11-09 21:17:38
Message-ID: 201011092117.39375.john () layt ! net
[Download RAW message or body]

On Tuesday 09 November 2010 20:19:18 David Faure wrote:
> On Tuesday 09 November 2010, Christian Ehrlicher wrote:
> > SVN commit 1194758 by chehrlic:
> > 
> > compile++
> > why does this compile with gcc?
> > 

> Good question. I guess because the base class doesn't have default values
> in the definition of the virtual method, and the derived method is never
> called directly.
> 
> John, shouldn't the derived methods be stripped from default values too?
> It's a bit weird otherwise. (or maybe I'm missing something)

Um, the base did/does have the same defaults, which Christian updated as well?  

KCalendarSystemPrivate:

  virtual QString stringFromInteger( int number,
                                     int padWidth = 0,
                                     QChar padChar = QLatin1Char('0') ) const;
  virtual QString stringFromInteger( int number,
                                     int padWidth,
                                     QChar padChar,
                                     KLocale::DigitSet digitSet ) const;

KCalendarSystemHebrewPrivate:

  virtual QString stringFromInteger( int number,
                                     int padWidth = 0,
                                     QChar padChar = QLatin1Char('0') ) const;
  virtual QString stringFromInteger( int number,
                                     int padWidth, 
                                     QChar padChar,
                                     KLocale::DigitSet digitSet ) const;

I'm a little lost here, what shouldn't work?

But then I'm scratching my head over why I have two methods, they're private 
so they could easily be merged.

John.
[prev in list] [next in list] [prev in thread] [next in thread]