[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore
From:       Christian Ehrlicher <Ch.Ehrlicher () gmx ! de>
Date:       2010-11-09 21:02:12
Message-ID: 4CD9B6D4.8070504 () gmx ! de
[Download RAW message or body]

Am 09.11.2010 21:44, schrieb David Faure:
> On Tuesday 09 November 2010, Christian Ehrlicher wrote:
>> Am 09.11.2010 21:23, schrieb David Faure:
>>> On Tuesday 09 November 2010, Christian Ehrlicher wrote:
>>>> Am 09.11.2010 21:06, schrieb David Faure:
>>>>> On Tuesday 09 November 2010, Christian Ehrlicher wrote:
>>>>>> SVN commit 1194753 by chehrlic:
>>>>>>
>>>>>> compile++
>>>>>
>>>>> Ouch, I could have at least done a pass over the _win.cpp files
>>>>> visually. Sorry for the additional work, and thanks for the fix.
>>>>>
>>>>> I'm also guilty for the qbytearray usage which made you add this in
>>>>>
>>>>> kstandarddirs.cpp:
>>>>>      gethostname(hostname, 255);
>>>>>      const QString localkdedir = m_prefixes.first();
>>>>>
>>>>> +    // this will not work on windows when localkdedir contains
>>>>> +    // characters not encodeable in the current locale
>>>>>
>>>>>      QByteArray dir = QFile::encodeName(localkdedir);
>>>>>      dir += type;
>>>>>      dir += '-';
>>>>>
>>>>> I forgot that the best representation of a path on Windows is a QString
>>>>> (while on unix one could argue that it's qbytearray, but none of the qt
>>>>> api takes that anyway).
>>>>>
>>>>> Shall I change it back to QString?
>>>>>
>>>>>   [with the risk to break compilation again, although I'll be careful
>>>>>   :)]
>>>>
>>>> It would be nice, yes :)
>>>
>>> Hmm how does readlink() work then on Windows? Doesn't it take a char*
>>> like on Unix?
>>
>> Yes, and then it will fail when it's not encodable. It's an own
>> implementation in kdewin library which should be enhanced to take an
>> utf16 string. But I currently can't do this.
> 
> OK, sounds like we should have a KDE_readlink in kde_file.h then?
> 
Yes, readlink should be wrapped the same why like the rest of the
low-level file functions.

Christian
[prev in list] [next in list] [prev in thread] [next in thread]