[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/widgets
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-10-08 12:21:36
Message-ID: 201010081421.36594.boud () valdyas ! org
[Download RAW message or body]

On Friday 08 October 2010, David Faure wrote:
> On Friday 08 October 2010, Boudewijn Rempt wrote:
> > SVN commit 1183781 by rempt:
> > 
> > Forward port r1183779
> > 
> > 
> > M  +1 -0      klineedit_p.h
> > 
> > 
> > --- trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h #1183780:1183781
> > @@ -186,6 +186,7 @@
> > m_overlap(0),
> > m_sentinel(false)
> > {
> > +      setParent(parent);
> > }
> 
> Hmm, the constructor  KdeUiProxyStyle(QWidget *parent);
> is indeed confusing, it makes one believe that this will become the QObject 
> parent. Either the setParent call should be moved to that class, or that 
> constructor should be documented as "NOT setting the qobject parent".
> Fredrik?

I originally had the setter in KdeUiProxyStyle, but Christoper Feck said

"It cannot be fixed at that place. If you are setting the same proxy style to \
multiple widgets, deleting the first of them would delete the proxy style. So it \
should be decided per subclass what to do."

> 
> I see that e.g. KHTMLProxyStyle calls setParent(parent) too, maybe this should 
> just be in the base class...



-- 
Boudewijn Rempt | http://www.valdyas.org
Ceterum censeo lapsum particulorum probae delendum esse


[prev in list] [next in list] [prev in thread] [next in thread]