[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/widgets
From:       David Faure <faure () kde ! org>
Date:       2010-10-08 12:18:39
Message-ID: 201010081418.40008.faure () kde ! org
[Download RAW message or body]

On Friday 08 October 2010, Boudewijn Rempt wrote:
> SVN commit 1183781 by rempt:
> 
> Forward port r1183779
> 
> 
>  M  +1 -0      klineedit_p.h
> 
> 
> --- trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h #1183780:1183781
> @@ -186,6 +186,7 @@
>        m_overlap(0),
>        m_sentinel(false)
>    {
> +      setParent(parent);
>    }

Hmm, the constructor  KdeUiProxyStyle(QWidget *parent);
is indeed confusing, it makes one believe that this will become the QObject 
parent. Either the setParent call should be moved to that class, or that 
constructor should be documented as "NOT setting the qobject parent".
Fredrik?

I see that e.g. KHTMLProxyStyle calls setParent(parent) too, maybe this should 
just be in the base class...

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]