[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdecore/services
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2010-09-12 18:54:13
Message-ID: 20100912185413.06BB1AC887 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1174531 by aacid:

Add some more QLatin1*, makes KMimeGlobsFileParser::parseGlobFile 1% faster


 M  +6 -6      kmimeglobsfileparser.cpp  


--- trunk/KDE/kdelibs/kdecore/services/kmimeglobsfileparser.cpp #1174530:1174531
@@ -82,10 +82,10 @@
     QString line;
     while (!stream.atEnd()) {
         line = stream.readLine();
-        if (line.isEmpty() || line.startsWith('#'))
+        if (line.isEmpty() || line.startsWith(QLatin1Char('#')))
             continue;
 
-        const QStringList fields = line.split(':', QString::KeepEmptyParts);
+        const QStringList fields = line.split(QLatin1Char(':'), \
QString::KeepEmptyParts);  if (fields.count() < 2) // syntax error
             continue;
 
@@ -101,7 +101,7 @@
             mimeTypeName = fields[1];
             pattern = fields[2];
             const QString flagsStr = fields.value(3); // could be empty
-            flagList = flagsStr.split(',', QString::SkipEmptyParts);
+            flagList = flagsStr.split(QLatin1Char(','), QString::SkipEmptyParts);
         } else {
             mimeTypeName = fields[0];
             pattern = fields[1];
@@ -118,12 +118,12 @@
             continue;
         }
 
-        bool caseSensitive = flagList.contains("cs");
+        bool caseSensitive = flagList.contains(QLatin1String("cs"));
 
-        if (caseSensitiveHackNeeded && (pattern == "*.C" || pattern == "*.c" || \
pattern == "core")) +        if (caseSensitiveHackNeeded && (pattern == \
QLatin1String("*.C") || pattern == QLatin1String("*.c") || pattern == \
QLatin1String("core")))  caseSensitive = true;
 
-        if (pattern == "__NOGLOBS__") {
+        if (pattern == QLatin1String("__NOGLOBS__")) {
             //kDebug() << "removing" << mimeTypeName;
             globs.removeMime(mimeTypeName);
             lastMime.clear();


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic