[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kword/part
From:       Jos van den Oever <jos () vandenoever ! info>
Date:       2010-08-03 16:49:00
Message-ID: 201008032218.12931.jos () vandenoever ! info
[Download RAW message or body]

On Tuesday, August 03, 2010 06:37:11 pm zander@kde.org wrote:
> On Tuesday 3. August 2010 11.14.22 Jos van den Oever wrote:
> > SVN commit 1158623 by vandenoever:
> > 
> > Fix typo.
> > 
> >  M  +1 -1      KWCanvasItem.h
> > 
> > --- trunk/koffice/kword/part/KWCanvasItem.h #1158622:1158623
> > @@ -41,7 +41,7 @@
> > 
> >   * the screen as well as the interaction with the user via mouse
> >   * and keyboard. There is one per view.
> >   */
> > 
> > -class KWCanvasItem : public QGraphicsWidget, public KWCanvasBase
> > +class KWORD_EXPORT KWCanvasItem : public QGraphicsWidget, public
> > KWCanvasBase {
> > 
> >      Q_OBJECT
> 
> What is the typo?
> This change incorrectly exports a class that should not be exported.
> 
> Let me know what the reason is for this change and we can search for a
> solution; I'll have to revert this change as the 'libkwordprivate' is not a
> library for usage outside of KWord. And KWord doesn't need this exported.

It was exported before I believe, but maybe that was a local patch. Indeed, 
the patch as such only adds the export, so it's ok to revert.

Cheers,
Jos

[prev in list] [next in list] [prev in thread] [next in thread]