[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kinit
From:       André_Wöbbeking <Woebbeking () kde ! org>
Date:       2010-07-26 11:01:57
Message-ID: 201007261301.58167.Woebbeking () kde ! org
[Download RAW message or body]

On Monday 26 July 2010, Ralf Habacker wrote:
> SVN commit 1154827 by
habacker:
> 
> using const is better
> 
>  M  +2 -2      kinit_win.cpp
> 
> 
>
--- trunk/KDE/kdelibs/kinit/kinit_win.cpp #1154826:1154827
> @@ -326,8 +326,8
@@
>          else
>          {
>              /// @todo KUser lacks domain
support yet: if user is in a
> domain skip process owner check for now because
it simply does not work - 
>           QString domain =
qgetenv("USERDOMAIN");
> -            QString host  =
qgetenv("COMPUTERNAME");
> +            const QString domain =
qgetenv("USERDOMAIN");
> +            const QString host  =
qgetenv("COMPUTERNAME");

Are these variables always in Latin1 or should you
use QString::fromLocal8Bit()?
[prev in list] [next in list] [prev in thread] [next in thread]