From kde-commits Mon Jul 26 11:01:57 2010 From: =?iso-8859-1?q?Andr=E9_W=F6bbeking?= Date: Mon, 26 Jul 2010 11:01:57 +0000 To: kde-commits Subject: Re: KDE/kdelibs/kinit Message-Id: <201007261301.58167.Woebbeking () kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=128014216220115 On Monday 26 July 2010, Ralf Habacker wrote: > SVN commit 1154827 by habacker: > > using const is better > > M +2 -2 kinit_win.cpp > > > --- trunk/KDE/kdelibs/kinit/kinit_win.cpp #1154826:1154827 > @@ -326,8 +326,8 @@ > else > { > /// @todo KUser lacks domain support yet: if user is in a > domain skip process owner check for now because it simply does not work - > QString domain = qgetenv("USERDOMAIN"); > - QString host = qgetenv("COMPUTERNAME"); > + const QString domain = qgetenv("USERDOMAIN"); > + const QString host = qgetenv("COMPUTERNAME"); Are these variables always in Latin1 or should you use QString::fromLocal8Bit()?